Separating Block
from Proposal
#2838
Replies: 4 comments
-
We could change the behavior of This method has some possible problems we might encounter, for example, Let's assume we would accept the block message when the proposal is in the |
Beta Was this translation helpful? Give feedback.
-
I have some questions for before about this suggestion.
|
Beta Was this translation helpful? Give feedback.
-
Also, I have some questions about this suggestion.
|
Beta Was this translation helpful? Give feedback.
-
I think this idea is good, though this can be huge chunk of work. |
Beta Was this translation helpful? Give feedback.
-
We have a marshaled
Block
in theProposal
. The previous decision was made due to a tricky proposed block-transferring timing situation. This should be separated at some point in my opinion and should be considered with specification changes.Block-transferring
A node needs to receive a block and the corresponding proposal before the Propose timeout to validate a proposed block and vote on it. The separation causes the change in the behavior of voting at the Propose -> PreVote stage.
libplanet/Libplanet.Net/Consensus/Context.cs
Lines 413 to 424 in 7a7faba
libplanet/Libplanet.Net/Consensus/Context.Mutate.cs
Lines 36 to 44 in 7a7faba
libplanet/Libplanet.Net/Consensus/Context.Mutate.cs
Lines 125 to 146 in 7a7faba
libplanet/Libplanet.Net/Consensus/MessageLog.cs
Lines 216 to 224 in 7a7faba
Evidence
Evidence is data for convicting the validator whose acts possibly lead to the fault of the consensus, and the example of those are the double vote (exceeding total quorum) and double proposal (minority proposal received validator will fall behind from the consensus).
Assuming that
I think this could be used as evidence and punish the validator later on. (Speculation) We can simply put the vote or proposal into the evidence list and validates the signature and compare it with the local evidence.
However, If we add the evidence into the
Block
andProposal
will have the marshaled block and that will cause the enlarging of the block size.Beta Was this translation helpful? Give feedback.
All reactions