From 58b8e49d9c973fa9e404d3face1d158299cec140 Mon Sep 17 00:00:00 2001 From: Graham Langford <30706330+grahamlangford@users.noreply.github.com> Date: Thu, 12 Sep 2024 12:07:08 -0500 Subject: [PATCH] fix slack notification (#9146) * fix slack notification * removed unnecessary checks --- .github/workflows/e2e-test-pre-release-browsers.yml | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/.github/workflows/e2e-test-pre-release-browsers.yml b/.github/workflows/e2e-test-pre-release-browsers.yml index 67ecda73d4..abd999c4b2 100644 --- a/.github/workflows/e2e-test-pre-release-browsers.yml +++ b/.github/workflows/e2e-test-pre-release-browsers.yml @@ -18,13 +18,10 @@ jobs: slack-notification: needs: end-to-end-tests runs-on: ubuntu-latest - if: ${{ job.status == 'failure' }} + if: ${{ always() && (needs.end-to-end-tests.result == 'failure') }} steps: - name: Slack Notification uses: rtCamp/action-slack-notify@v2 - with: - status: ${{ job.status }} - notify_when: "failure" env: SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK }} SLACK_CHANNEL: playwright-playground