ESLint Plugin Import - prefer-default-export

[grahamlangford]

https://github.com/import-js/eslint-plugin-import/blob/main/docs/rules/prefer-default-export.md

[fregante]

I tried enabling this, there are 165 errors in the extension. While I always use this rule, I don’t think it would be well-liked

https://github.com/pixiebrix/pixiebrix-extension/actions/runs/6439735844/job/17487763557

[grahamlangford]

This was added as a result of a comment on an old PR: pixiebrix/pixiebrix-extension#6115 (comment)

It's not a priority. I'll discuss it with the engineering team before we move forward. With the number of errors, we'd likely make it a warning first if we move forward with it at all.

[grahamlangford]

Alternatively, we could enforce only named exports using https://github.com/import-js/eslint-plugin-import/blob/main/docs/rules/no-default-export.md. I'm not strongly tied to either approach, just looking for consistency.

[fregante]

• 758 results for "export default"

I'd say prefer-default-export is still preferable 😃

[grahamlangford]

Looks like the team prefers prefer-default-export anyway: https://pixiebrix.slack.com/archives/C023KL47XV4/p1697040027674289

Not a priority to fix. I support turning it on as a warning for now.