Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Labels scroll down the page as canvas is scrolled horizontally #86

Open
gingerbeardman opened this issue Feb 10, 2022 · 7 comments
Open

Comments

@gingerbeardman
Copy link

gingerbeardman commented Feb 10, 2022

See this screen recording for the bug:

https://imgur.com/FgSQorf

Screenshot:
Screen shot 2022-02-10 at 15 14 20

@onli
Copy link
Member

onli commented Feb 10, 2022

Hi @gingerbeardman . Thanks for the report. Which browser is this?

The label scrolling is done by JavaScript, and it's sadly indeed possible that it breaks in other browsers.

@gingerbeardman
Copy link
Author

gingerbeardman commented Feb 10, 2022

Hi, this is the very latest Safari 15.3 (17612.4.9.1.5) on macOS 12.2 (21D49)

In other browsers I see different but similar problems...

Chrome 98.0.4758.80
Screen shot 2022-02-10 at 16 06 20

Opera 83.0
Screen shot 2022-02-10 at 16 07 34

@gingerbeardman gingerbeardman changed the title Labels scroll down the page as canvas is scrolled Labels scroll down the page as canvas is scrolled horizontally Feb 10, 2022
@onli
Copy link
Member

onli commented Feb 10, 2022

Strange, Chrome I test of course. Safari is hard to test since it's proprietary and not available on Linux, but Chrome should've worked - and I can't reproduce it yet. Could you send me the pipe where this breaks? If you don't want to have it public you could send it by mail to [email protected].

Also consider testing with Firefox, that's the browser that sees the most testing.

@gingerbeardman
Copy link
Author

Correct pipe is DNJyxk9a

@onli
Copy link
Member

onli commented Jan 9, 2024

I will close here. For now, Safari is out of scope.

I'm aware that the editor UI is not completely stable and can break with new browser version. One idea to solve this for good would be to re-implement the whole thing with Flutter. While I'm not generally a fan of Flutter for the Web, this canvas here seems like a perfect use case - it can not be done in HTML anyway, and the implementation would be a lot more stable.

@onli onli closed this as completed Jan 9, 2024
@gingerbeardman
Copy link
Author

gingerbeardman commented Jan 10, 2024

Safari is out of scope?

WebKit 27% of browser market share (Chrome is 59%)
https://www.similarweb.com/browsers/

@onli
Copy link
Member

onli commented Jan 10, 2024

I'm simply not able to test with Safari. But we can also keep this open and ask for help instead? If someone wanted to provide patches for the editor javascript/css, I'd happily merge them!

@onli onli reopened this Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants