Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Outdated type on ListingAsset? #6

Open
schoenwaldnils opened this issue Apr 8, 2021 · 0 comments · May be fixed by #7
Open

Outdated type on ListingAsset? #6

schoenwaldnils opened this issue Apr 8, 2021 · 0 comments · May be fixed by #7

Comments

@schoenwaldnils
Copy link

schoenwaldnils commented Apr 8, 2021 •
edited
Loading

Hi, I'm on v0.1.1

could it be that ListingAsset type is outdated?

I get:

actions: Pick<Auction, 'market_contract' | 'auction_id'>[]

the package types expect:

action: Pick<Auction, 'market_contract' | 'auction_id'>

Would also be interesting to know why the change to an array 🤔
Shouldn't just one auction be able on an asset? 🤔
@schoenwaldnils schoenwaldnils linked a pull request Apr 8, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update ListingAsset auction to auctions schoenwaldnils/atomicmarket-js
1 participant
@schoenwaldnils