Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pico Synth & i2s Audio Libraries #963

Open
Gadgetoid opened this issue Jun 25, 2024 · 0 comments
Open

Pico Synth & i2s Audio Libraries #963

Gadgetoid opened this issue Jun 25, 2024 · 0 comments

Comments

@Gadgetoid
Copy link
Member

Right now Pico Synth exists in a sort of purgatory- it includes an hpp and cpp file which can be included piecemeal into another project, but doesn't have a CMake file to make it easy to do this. As such using it results in stuff like:

#include "../pico_synth/pico_synth.hpp"

and:

${CMAKE_CURRENT_LIST_DIR}/../pico_synth/pico_synth.cpp

Which is functional, but ugly.

In addition to this, identical functions for bringing up audio and running Pico Synth over i2s appear in the Cosmic, Galactic and Stellar Unicorn libraries.

Normally we'd need to fix this in short order, since repeating this code across 3 libraries is throwing away flash memory bytes we're already really short of, but we build separate Cosmic, Stellar and Galactic firmwares which just include their own drives and thus one copy of synth and the audio driver.

This issue is a gentle reminder to myself to "fix" this when I've got the time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant