Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report test statistics to elastic #907

Merged
merged 5 commits into from
Jan 10, 2024
Merged

Report test statistics to elastic #907

merged 5 commits into from
Jan 10, 2024

Conversation

msimberg
Copy link
Contributor

No description provided.

@msimberg msimberg self-assigned this Dec 19, 2023
@msimberg
Copy link
Contributor Author

cscs-ci run

@msimberg msimberg force-pushed the test-statistics-elastic-cscs-ci branch from 636ef35 to 0876c00 Compare December 19, 2023 10:13
@msimberg
Copy link
Contributor Author

cscs-ci run

@pika-bot
Copy link
Collaborator

Performance test report

@msimberg msimberg force-pushed the test-statistics-elastic-cscs-ci branch from 0876c00 to c1455c4 Compare December 19, 2023 10:33
@msimberg
Copy link
Contributor Author

cscs-ci run

@pika-bot
Copy link
Collaborator

Performance test report

@msimberg msimberg force-pushed the test-statistics-elastic-cscs-ci branch from c1455c4 to 0672e4f Compare December 19, 2023 10:59
@msimberg
Copy link
Contributor Author

cscs-ci run

@pika-bot
Copy link
Collaborator

Performance test report

@msimberg msimberg force-pushed the test-statistics-elastic-cscs-ci branch from 0672e4f to 02995a4 Compare December 19, 2023 12:10
@msimberg
Copy link
Contributor Author

cscs-ci run

@msimberg msimberg force-pushed the test-statistics-elastic-cscs-ci branch from 02995a4 to e4240cb Compare December 19, 2023 12:14
@msimberg
Copy link
Contributor Author

cscs-ci run

@msimberg msimberg force-pushed the test-statistics-elastic-cscs-ci branch from e4240cb to f68de62 Compare December 19, 2023 12:19
@msimberg
Copy link
Contributor Author

cscs-ci run

@pika-bot
Copy link
Collaborator

Performance test report

1 similar comment
@pika-bot
Copy link
Collaborator

Performance test report

@msimberg msimberg force-pushed the test-statistics-elastic-cscs-ci branch from f68de62 to 16aad91 Compare December 19, 2023 13:23
@pika-bot
Copy link
Collaborator

Performance test report

@msimberg msimberg force-pushed the test-statistics-elastic-cscs-ci branch from 16aad91 to e28ea16 Compare December 19, 2023 14:06
@msimberg
Copy link
Contributor Author

cscs-ci run

@pika-bot
Copy link
Collaborator

Performance test report

@msimberg msimberg force-pushed the test-statistics-elastic-cscs-ci branch from e28ea16 to b3b8268 Compare December 19, 2023 16:18
@msimberg
Copy link
Contributor Author

cscs-ci run

@pika-bot
Copy link
Collaborator

Performance test report

@msimberg msimberg force-pushed the test-statistics-elastic-cscs-ci branch from b3b8268 to 87c1ed5 Compare January 3, 2024 11:37
@msimberg
Copy link
Contributor Author

msimberg commented Jan 3, 2024

cscs-ci run

@pika-bot
Copy link
Collaborator

pika-bot commented Jan 3, 2024

Performance test report

@msimberg
Copy link
Contributor Author

msimberg commented Jan 4, 2024

cscs-ci run

1 similar comment
@msimberg
Copy link
Contributor Author

msimberg commented Jan 5, 2024

cscs-ci run

@msimberg msimberg force-pushed the test-statistics-elastic-cscs-ci branch from e778ebd to bd6b230 Compare January 5, 2024 10:49
@pika-bot
Copy link
Collaborator

pika-bot commented Jan 5, 2024

Performance test report

pika Performance

Comparison

BENCHMARKRESULT
Task Overhead - Create Thread Hierarchical - Latch-

Info

PropertyBeforeAfter
pika Commit02f9de8feb6246
pika Datetime2023-08-21T11:44:55+00:002024-01-05T10:49:10+00:00
Compiler/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1
Clusternamedaintdaint
Hostnamenid01181nid01619
Envfile
Datetime2023-08-21T13:50:51.685166+02:002024-01-05T11:57:41.350441+01:00

Explanation of Symbols

SymbolMEANING
=No performance change (confidence interval within ±1%)
(=)Probably no performance change (confidence interval within ±2%)
(+)/(-)Very small performance improvement/degradation (≤1%)
+/-Small performance improvement/degradation (>10%)
++/--Large performance improvement/degradation (>10%)
+++/---Very large performance improvement/degradation (>10%)
?Probably no change, but quite large uncertainty (confidence interval with ±5%)
??Unclear result, very large uncertainty (±10%)
???Something unexpected…

@msimberg
Copy link
Contributor Author

msimberg commented Jan 5, 2024

cscs-ci run

@msimberg msimberg force-pushed the test-statistics-elastic-cscs-ci branch from bd6b230 to c27076b Compare January 5, 2024 11:07
@msimberg
Copy link
Contributor Author

msimberg commented Jan 5, 2024

cscs-ci run

@msimberg msimberg force-pushed the test-statistics-elastic-cscs-ci branch from c27076b to 12f624c Compare January 5, 2024 11:22
@msimberg
Copy link
Contributor Author

msimberg commented Jan 5, 2024

cscs-ci run

@msimberg msimberg marked this pull request as ready for review January 5, 2024 13:16
aurianer
aurianer approved these changes Jan 8, 2024
View reviewed changes
Copy link
Contributor

@aurianer aurianer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks a lot for this! (Approved modulo the codacy failures)

.gitlab/includes/clang11_pipeline.yml Outdated Show resolved Hide resolved
@msimberg msimberg force-pushed the test-statistics-elastic-cscs-ci branch from 12f624c to 7cd63e1 Compare January 9, 2024 13:26
@msimberg
Copy link
Contributor Author

msimberg commented Jan 9, 2024

Waiting for #846 to be merged before this. I will add the test reporting to the newly added HIP configuration once #846 is in.

@msimberg
Copy link
Contributor Author

msimberg commented Jan 9, 2024

cscs-ci run

@msimberg msimberg force-pushed the test-statistics-elastic-cscs-ci branch from 7cd63e1 to 8ae3a84 Compare January 10, 2024 12:45
@msimberg
Copy link
Contributor Author

cscs-ci run

@msimberg msimberg added this pull request to the merge queue Jan 10, 2024
@msimberg msimberg added this to the 0.22.0 milestone Jan 10, 2024
Merged via the queue into pika-org:main with commit 9ccc1d5 Jan 10, 2024
64 of 66 checks passed
This was referenced Jan 11, 2024
Merged
Open
@msimberg msimberg deleted the test-statistics-elastic-cscs-ci branch January 24, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aurianer aurianer aurianer approved these changes

@biddisco biddisco Awaiting requested review from biddisco biddisco is a code owner

Assignees

@msimberg msimberg

Labels
None yet
Projects
pika planning board
Archived in project
Milestone
0.22.0
Development

Successfully merging this pull request may close these issues.
3 participants
@msimberg @pika-bot @aurianer