Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add clang configurations for CSCS CI #857

Merged
merged 3 commits into from
Nov 20, 2023
Merged

Add clang configurations for CSCS CI #857

merged 3 commits into from
Nov 20, 2023

Conversation

aurianer
Copy link
Contributor

@aurianer aurianer commented Nov 13, 2023 •
edited
Loading

Fixes partially #32.

@aurianer aurianer added the category: CI Continuous Integration label Nov 13, 2023
@aurianer aurianer added this to the 0.21.0 milestone Nov 13, 2023
@aurianer aurianer self-assigned this Nov 13, 2023
@aurianer
Copy link
Contributor Author

cscs-ci run

@aurianer
Copy link
Contributor Author

Just to have some references here, it seems like I can't install [email protected] with [email protected], I'll try another version for libffi and see if we use the same in the jenkins pipeline
https://gitlab.com/cscs-ci/ci-testing/webhook-ci/mirrors/479009878135925/5304355110917878/-/jobs/5529513221

@aurianer
Copy link
Contributor Author

cscs-ci run

@msimberg
Copy link
Contributor

Just to have some references here, it seems like I can't install [email protected] with [email protected], I'll try another version for libffi and see if we use the same in the jenkins pipeline https://gitlab.com/cscs-ci/ci-testing/webhook-ci/mirrors/479009878135925/5304355110917878/-/jobs/5529513221

Looks like it's fixed by this possibly: https://github.com/libffi/libffi/pull/764/files? However, there's no release with those changes yet. Perhaps worth a patch to spack?

@pika-bot
Copy link
Collaborator

Performance test report

pika Performance

Comparison

BENCHMARKNO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch-

Info

PropertyBeforeAfter
pika Datetime2023-08-21T11:44:55+00:002023-11-14T10:35:26+00:00
pika Commit02f9de8306b143
Compiler/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1
Clusternamedaintdaint
Hostnamenid01181nid00266
Envfile
Datetime2023-08-21T13:50:51.685166+02:002023-11-14T11:44:36.937083+01:00

Explanation of Symbols

SymbolMEANING
=No performance change (confidence interval within ±1%)
(=)Probably no performance change (confidence interval within ±2%)
(+)/(-)Very small performance improvement/degradation (≤1%)
+/-Small performance improvement/degradation (>10%)
++/--Large performance improvement/degradation (>10%)
+++/---Very large performance improvement/degradation (>10%)
?Probably no change, but quite large uncertainty (confidence interval with ±5%)
??Unclear result, very large uncertainty (±10%)
???Something unexpected…

@aurianer aurianer force-pushed the add_other_configs_cscsci branch 2 times, most recently from c130bbb to 082cce7 Compare November 17, 2023 10:34
@aurianer
Copy link
Contributor Author

cscs-ci run

@pika-bot
Copy link
Collaborator

Performance test report

pika Performance

Comparison

BENCHMARKNO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch-

Info

PropertyBeforeAfter
pika Datetime2023-08-21T11:44:55+00:002023-11-17T10:34:04+00:00
pika Commit02f9de83a74447
Clusternamedaintdaint
Envfile
Datetime2023-08-21T13:50:51.685166+02:002023-11-17T11:40:21.216324+01:00
Hostnamenid01181nid00596
Compiler/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1

Explanation of Symbols

SymbolMEANING
=No performance change (confidence interval within ±1%)
(=)Probably no performance change (confidence interval within ±2%)
(+)/(-)Very small performance improvement/degradation (≤1%)
+/-Small performance improvement/degradation (>10%)
++/--Large performance improvement/degradation (>10%)
+++/---Very large performance improvement/degradation (>10%)
?Probably no change, but quite large uncertainty (confidence interval with ±5%)
??Unclear result, very large uncertainty (±10%)
???Something unexpected…

@aurianer aurianer marked this pull request as ready for review November 18, 2023 19:24
@aurianer
Copy link
Contributor Author

cscs-ci run

@aurianer aurianer closed this Nov 18, 2023
@aurianer aurianer reopened this Nov 18, 2023
@aurianer
Copy link
Contributor Author

cscs-ci run

@pika-bot
Copy link
Collaborator

Performance test report

pika Performance

Comparison

BENCHMARKNO-EXECUTOR
Future Overhead - Create Thread Hierarchical - Latch-

Info

PropertyBeforeAfter
pika Commit02f9de8c484614
pika Datetime2023-08-21T11:44:55+00:002023-11-19T20:47:29+00:00
Datetime2023-08-21T13:50:51.685166+02:002023-11-19T21:54:38.300984+01:00
Envfile
Clusternamedaintdaint
Compiler/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1/apps/daint/SSL/pika/spack/lib/spack/env/clang/clang++ 11.0.1
Hostnamenid01181nid00612

Explanation of Symbols

SymbolMEANING
=No performance change (confidence interval within ±1%)
(=)Probably no performance change (confidence interval within ±2%)
(+)/(-)Very small performance improvement/degradation (≤1%)
+/-Small performance improvement/degradation (>10%)
++/--Large performance improvement/degradation (>10%)
+++/---Very large performance improvement/degradation (>10%)
?Probably no change, but quite large uncertainty (confidence interval with ±5%)
??Unclear result, very large uncertainty (±10%)
???Something unexpected…

@aurianer
Copy link
Contributor Author

I currently have a problem with the clang14_cuda11 configuration so I will investigate it in a separate PR (#861)

@aurianer
Copy link
Contributor Author

So this PR is now ready to go

msimberg
msimberg approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@msimberg msimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

We definitely need to try to reduce the duplication between the configs, but does not need to be done here. Opened #862 to keep track of it.

@msimberg msimberg added this pull request to the merge queue Nov 20, 2023
Merged via the queue into pika-org:main with commit 4adb9ec Nov 20, 2023
66 of 67 checks passed
@aurianer aurianer deleted the add_other_configs_cscsci branch November 21, 2023 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msimberg msimberg msimberg approved these changes

@biddisco biddisco Awaiting requested review from biddisco biddisco is a code owner

Assignees

@aurianer aurianer

Labels
category: CI Continuous Integration
Projects
pika planning board
Status: Archive
Milestone
0.21.0
Development

Successfully merging this pull request may close these issues.
3 participants
@aurianer @msimberg @pika-bot