From 3b63591f8f968d12f88372305db43f9e0c886af0 Mon Sep 17 00:00:00 2001 From: Mikael Simberg Date: Wed, 11 Sep 2024 14:12:17 +0200 Subject: [PATCH] Disable lock registration on address sanitizer CI configuration --- .github/workflows/linux_asan_ubsan_lsan.yml | 1 + libs/pika/resource_partitioner/tests/unit/CMakeLists.txt | 4 ---- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/.github/workflows/linux_asan_ubsan_lsan.yml b/.github/workflows/linux_asan_ubsan_lsan.yml index 7b34dd765..552dac3ee 100644 --- a/.github/workflows/linux_asan_ubsan_lsan.yml +++ b/.github/workflows/linux_asan_ubsan_lsan.yml @@ -59,6 +59,7 @@ jobs: -DPIKA_WITH_COMPILER_WARNINGS=ON \ -DPIKA_WITH_COMPILER_WARNINGS_AS_ERRORS=ON \ -DPIKA_WITH_SANITIZERS=On \ + -DPIKA_WITH_VERIFY_LOCKS=Off \ -DCMAKE_CXX_FLAGS="-fsanitize=address -fsanitize-address-use-after-scope -fsanitize=undefined -fno-omit-frame-pointer -Wno-error=ignored-optimization-argument" \ -DPIKA_WITH_STACKOVERFLOW_DETECTION=Off \ -DPIKA_WITH_CHECK_MODULE_DEPENDENCIES=On diff --git a/libs/pika/resource_partitioner/tests/unit/CMakeLists.txt b/libs/pika/resource_partitioner/tests/unit/CMakeLists.txt index 92374cf72..19c1050a6 100644 --- a/libs/pika/resource_partitioner/tests/unit/CMakeLists.txt +++ b/libs/pika/resource_partitioner/tests/unit/CMakeLists.txt @@ -22,10 +22,6 @@ set(tests ) set(cross_pool_injection_PARAMETERS THREADS -1) -if(PIKA_WITH_SANITIZERS) - # This test triggers a possible false positive stack-use-after-scope in lock registration - list(APPEND cross_pool_injection_PARAMETERS "--pika:ini=pika.lock_detection=0") -endif() set(scheduler_binding_check_PARAMETERS THREADS -1) set(named_pool_executor_PARAMETERS THREADS 4)