Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase the specificity of the return type of _get_list_table() #210

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

johnbillion
Copy link
Contributor

We have the technology.

@szepeviktor szepeviktor merged commit 4582a67 into php-stubs:master Aug 27, 2024
5 checks passed
@johnbillion johnbillion deleted the list-tables branch August 27, 2024 10:04
@IanDelMar
Copy link
Contributor

IanDelMar commented Aug 27, 2024

But this returns an incorrect type when the class name is filtered.

@johnbillion
Copy link
Contributor Author

Correct but it's surely more useful for the return type to be more specific 99% of the time.

@szepeviktor
Copy link
Member

99% of the time

👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants