Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maybe it's a good idea to change XML serialization library? #52

Open
skatkov opened this issue Dec 29, 2017 · 2 comments
Open

Maybe it's a good idea to change XML serialization library? #52

skatkov opened this issue Dec 29, 2017 · 2 comments

Comments

@skatkov
Copy link

skatkov commented Dec 29, 2017

I've ran into an issue that data returned from amazon had different property names ('TinyImage' vs 'tiny_image') -- that caused me to write a lot of hacks and wordarounds to deal with. While i expected asin library and code seemed reasonable, i was really puzzled why would amazon do such a thing with me (or us) :D

But I think that this weirdness is explained by one of dependencies used in this project, it has a code like this:

https://github.com/jnunemaker/crack/blob/master/lib/crack/util.rb

I don't think that altering objects is a good idea for any Xml serialization library. So maybe it's a good opportunity to change dependency to something like multiXml ( https://github.com/sferik/multi_xml ) ?

@skatkov
Copy link
Author

skatkov commented Dec 29, 2017

I'm attaching two different end-result file examples that illustrate my problem.
Archive.zip

@phoet
Copy link
Owner

phoet commented Dec 29, 2017

@skatkov if you are willing to provide a PR to change the existing implementation I will be happy to merge it in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants