Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

queryParameters from nested traits is not honored in generated code #287

Open
techpavan opened this issue Sep 26, 2018 · 2 comments
Open
Labels
bug raml-parser-2 Issue related to raml-parser-2 project v2 Feature will be implemented in v2.0 only (master branch)

Comments

@techpavan
Copy link

Found that applying the workaround in #283 by using required: false rather than short-hand notation is effective only when traits are directly referenced. If a trait is referring to a different trait which has queryParameters, the nested trait's queryParameters do not reflect in the generated code.

Reproducer - Clone the code from https://github.com/techpavan/springmvc-raml-plugin-issues/ and check the code generated to list all the bus brands against for the car brands.

@stojsavljevic
Copy link
Contributor

Can you please check if the issue is related to raml-parser-2?
There is a link to raml-parser-2 bug in #283 where you can find the way to reproduce issues with the parser.

@stojsavljevic stojsavljevic added waiting for response v2 Feature will be implemented in v2.0 only (master branch) labels Sep 26, 2018
@techpavan
Copy link
Author

Right. Its an issue from the raml-parser-2 project. Have submitted an issue there.

raml-org/raml-java-parser#558

@stojsavljevic stojsavljevic added bug raml-parser-2 Issue related to raml-parser-2 project and removed waiting for response labels Sep 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug raml-parser-2 Issue related to raml-parser-2 project v2 Feature will be implemented in v2.0 only (master branch)
Projects
None yet
Development

No branches or pull requests

2 participants