Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

several bugs in run_omniCLIP #27

Open
vagarwal87 opened this issue Mar 4, 2021 · 0 comments
Open

several bugs in run_omniCLIP #27

vagarwal87 opened this issue Mar 4, 2021 · 0 comments

Comments

@vagarwal87
Copy link

A few bugs for people to be aware of, since the Viterbi can take days and then program terminates unsuccessfully, which can be a bit frustrating:

  1. There isn't any description that the db file must end in ".db", so my GeneAnnotation was never set up:

if args.gene_anno_file.split('.')[-1] == 'db':
GeneAnnotation = gffutils.FeatureDB(args.gene_anno_file, keep_order=True)

I ended up just commenting out the "if" statement and it worked fine. Or you can write in README that it must end in .db

  1. I added the following lines:

    if not os.path.exists(EmissionParameters['out_dir']): <------ added
    os.makedirs(EmissionParameters['out_dir']) <------ added

    OutFile = os.path.join(EmissionParameters['out_dir'],
    EmissionParameters['out_file_base'] + '.txt')

because if the output directory doesn't already exist, it would terminate w/ error.

  1. --nb-cores > 1 doesn't work for some reason though my hardware has 8 cores...for now just using 1. Possibly this is something weird w/ multiprocessing module & my system, though.

  2. it would be helpful in general to describe whether this package is intended for ALL CLIP? I thought so initially, but one of the open comments suggests that you're still evaluating T->C mutations w/ PAR-CLIP. Is it okay to use this with iCLIP/eCLIP/HITS-CLIP or is it always using mutations to evaluate significance?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant