Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed h5py handles - FitEmissionParameters #21

Open
simojoe opened this issue Aug 5, 2020 · 0 comments
Open

Closed h5py handles - FitEmissionParameters #21

simojoe opened this issue Aug 5, 2020 · 0 comments

Comments

@simojoe
Copy link
Collaborator

simojoe commented Aug 5, 2020

The FitEmissionParameters function make use of if 'Pseudo' in Sequences: statements to verify if the pseudo-gene has been added to the Sequences file. However, if the h5py file handle is closed, the if statement will return a False value without throwing an error. Using if 'Pseudo' in list(Sequences.keys()) will throw an error if the file handle is closed.

This is an issue because several functions called from FitEmissionParameters seem to be returning closed file handles. Therefore the tests at the end of FitEmissionParameters are all being evaluated as False.

@simojoe simojoe changed the title Close h5py handles Closed h5py handles - FitEmissionParameters Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant