Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample ID's matching the same id in the reference cluster files are not assigned into heirarchy #6

Open
jrober84 opened this issue May 7, 2024 · 0 comments

Comments

@jrober84
Copy link
Collaborator

jrober84 commented May 7, 2024

If the user supplies a set of query samples B,C into an existing set of clusters A,B,C,D, they will be assigned new cluster codes all the way through as they will be treated as too distant to assign due to a skip on line 188 in assign.py

            if q_id in self.memberships_dict:
                continue

options for solving.

  1. Check for containment of the same sample id's in the query as in the clusters and fail if true. User needs to remove them.

  2. Allow for shadowing of sample_id's in the data and still perform the assignment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant