From c13b62300c66c0df864733734cf4a7ee800433f7 Mon Sep 17 00:00:00 2001
From: Frode Flaten <3436158+fflaten@users.noreply.github.com>
Date: Wed, 31 Jul 2024 12:34:15 +0000
Subject: [PATCH] Fix test for strict mode

---
 tst/functions/Add-ShouldOperator.ts.ps1 | 23 +++++++++--------------
 1 file changed, 9 insertions(+), 14 deletions(-)

diff --git a/tst/functions/Add-ShouldOperator.ts.ps1 b/tst/functions/Add-ShouldOperator.ts.ps1
index 46681724d..8fa303e06 100644
--- a/tst/functions/Add-ShouldOperator.ts.ps1
+++ b/tst/functions/Add-ShouldOperator.ts.ps1
@@ -80,13 +80,10 @@ i -PassThru:$PassThru {
                 $succeeded = 'A' -eq $ActualValue
                 if ($Negate) { $succeeded = -not $succeeded }
 
-                if (-not $succeeded) {
-                    if ($Negate) {
-                        $failureMessage = "Expected anything but 'A', but got '$ActualValue'."
-                    }
-                    else {
-                        $failureMessage = "Expected 'A', but got '$ActualValue'."
-                    }
+                # Default failure message. Not used by Should unless succeeded is $false
+                $failureMessage = "Expected 'A', but got '$ActualValue'."
+                if (-not $succeeded -and $Negate) {
+                    $failureMessage = "Expected anything but 'A', but got '$ActualValue'."
                 }
 
                 return [pscustomobject]@{
@@ -114,15 +111,13 @@ i -PassThru:$PassThru {
                 $succeeded = 'A' -eq $ActualValue
                 if ($Negate) { $succeeded = -not $succeeded }
 
-                if (-not $succeeded) {
-                    if ($Negate) {
-                        $failureMessage = "Expected anything but 'A', but got '$ActualValue'."
-                    }
-                    else {
-                        $failureMessage = "Expected 'A', but got '$ActualValue'."
-                    }
+                # Default failure message. Not used by Should unless succeeded is $false
+                $failureMessage = "Expected 'A', but got '$ActualValue'."
+                if (-not $succeeded -and $Negate) {
+                    $failureMessage = "Expected anything but 'A', but got '$ActualValue'."
                 }
 
+
                 return [pscustomobject]@{
                     Succeeded      = $succeeded
                     FailureMessage = $failureMessage