PMM-12641 Cleanup server build scripts #3217
Open
+14
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v3 #3217 +/- ##
==========================================
+ Coverage 44.59% 44.62% +0.03%
==========================================
Files 357 357
Lines 35719 35719
==========================================
+ Hits 15929 15941 +12
+ Misses 18167 18154 -13
- Partials 1623 1624 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ademidoff
commented
Sep 30, 2024
build/docker/server/Dockerfile.el9
Outdated
| @@ -38,10 +30,21 @@ COPY pmm-client.tar.gz /tmp/ | |||
| RUN install -T -p -m 644 /opt/ansible/ansible.cfg /etc/ansible/ansible.cfg && \ | |||
| ansible-playbook -vvv -i 'localhost,' -c local /opt/ansible/pmm-docker/main.yml -e "pmm_running_in_docker=true" && \ | |||
| ansible-playbook -vvv -i 'localhost,' -c local /opt/ansible/pmm-docker/update.yml -e "pmm_running_in_docker=true" && \ | |||
| ansible-playbook -vvv -i 'localhost,' -c local /opt/ansible/pmm/post-build-actions.yml -e "pmm_running_in_docker=true" | |||
| ansible-playbook -vvv -i 'localhost,' -c local /opt/ansible/pmm/post-build-actions.yml -e "pmm_running_in_docker=true" && \ | |||
There was a problem hiding this comment.
@talhabinrizwan FYI: I'm removing those pmm_running_in_docker vars as they don't seem to be used in v3.
ademidoff
requested review from
BupycHuk,
idoqo and
talhabinrizwan
and removed request for
a team
idoqo
approved these changes
Oct 4, 2024
BupycHuk
approved these changes
Oct 8, 2024
Comment on lines
-39
to
-41
| ansible-playbook -vvv -i 'localhost,' -c local /opt/ansible/pmm-docker/main.yml -e "pmm_running_in_docker=true" && \ | ||
| ansible-playbook -vvv -i 'localhost,' -c local /opt/ansible/pmm-docker/update.yml -e "pmm_running_in_docker=true" && \ | ||
| ansible-playbook -vvv -i 'localhost,' -c local /opt/ansible/pmm/post-build-actions.yml -e "pmm_running_in_docker=true" |
There was a problem hiding this comment.
is pmm_running_in_docker used anywhere?
There was a problem hiding this comment.
Yes, it's still being used in v2, but not in v3 :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PMM-12641
Link to the Feature Build: SUBMODULES-3720
If this PR adds or removes or alters one or more API endpoints, please review and add or update the relevant API documents as well:
If this PR is related to some other PRs in this or other repositories, please provide links to those PRs: