From 44b13ea47e815c7f31b7ea1cce652a35ff0f8a71 Mon Sep 17 00:00:00 2001 From: yurkovychv Date: Mon, 2 Sep 2024 16:08:20 +0300 Subject: [PATCH 1/3] PMM-7 fix settings tests --- tests/configuration/verifyPMMSettingsPageElements_test.js | 2 ++ tests/configuration/verifyPMMSettingsPageFunctionality_test.js | 1 + 2 files changed, 3 insertions(+) diff --git a/tests/configuration/verifyPMMSettingsPageElements_test.js b/tests/configuration/verifyPMMSettingsPageElements_test.js index b8ce9ab32..1c32dc1dc 100644 --- a/tests/configuration/verifyPMMSettingsPageElements_test.js +++ b/tests/configuration/verifyPMMSettingsPageElements_test.js @@ -187,6 +187,8 @@ Scenario('@PMM-T1866 - Verify if public address has an port assigned and followi I.fillField(pmmSettingsPage.fields.publicAddressInput, '192.168.1.1:8433'); pmmSettingsPage.applyChanges(); I.dontSeeElement(pmmSettingsPage.fields.errorPopUpElement); + I.wait(5); + I.refreshPage(); await pmmSettingsPage.verifySettingsValue(pmmSettingsPage.fields.publicAddressInput, '192.168.1.1:8433'); // clearField and customClearField methods doesn't work for this field I.usePlaywrightTo('clear field', async ({ page }) => { diff --git a/tests/configuration/verifyPMMSettingsPageFunctionality_test.js b/tests/configuration/verifyPMMSettingsPageFunctionality_test.js index b4d8d6f28..df9fbf075 100644 --- a/tests/configuration/verifyPMMSettingsPageFunctionality_test.js +++ b/tests/configuration/verifyPMMSettingsPageFunctionality_test.js @@ -347,6 +347,7 @@ Scenario( I.assertTrue(publicAddressValue.length > 0, 'Expected the Public Address Input Field to be not empty!'); pmmSettingsPage.applyChanges(); + I.wait(5); I.refreshPage(); await pmmSettingsPage.waitForPmmSettingsPageLoaded(); const publicAddressAfterRefresh = await I.grabValueFrom(pmmSettingsPage.fields.publicAddressInput); From f47dda1e4cdcf367a9fc615bf619e22774c21156 Mon Sep 17 00:00:00 2001 From: yurkovychv Date: Tue, 3 Sep 2024 11:52:49 +0300 Subject: [PATCH 2/3] PMM-7 add bug reference --- tests/configuration/verifyPMMSettingsPageElements_test.js | 2 ++ tests/configuration/verifyPMMSettingsPageFunctionality_test.js | 1 + 2 files changed, 3 insertions(+) diff --git a/tests/configuration/verifyPMMSettingsPageElements_test.js b/tests/configuration/verifyPMMSettingsPageElements_test.js index 1c32dc1dc..6c9ff54d1 100644 --- a/tests/configuration/verifyPMMSettingsPageElements_test.js +++ b/tests/configuration/verifyPMMSettingsPageElements_test.js @@ -187,6 +187,8 @@ Scenario('@PMM-T1866 - Verify if public address has an port assigned and followi I.fillField(pmmSettingsPage.fields.publicAddressInput, '192.168.1.1:8433'); pmmSettingsPage.applyChanges(); I.dontSeeElement(pmmSettingsPage.fields.errorPopUpElement); + + // Remove wait after https://perconadev.atlassian.net/browse/PMM-13340 is fixed I.wait(5); I.refreshPage(); await pmmSettingsPage.verifySettingsValue(pmmSettingsPage.fields.publicAddressInput, '192.168.1.1:8433'); diff --git a/tests/configuration/verifyPMMSettingsPageFunctionality_test.js b/tests/configuration/verifyPMMSettingsPageFunctionality_test.js index df9fbf075..eabb3186b 100644 --- a/tests/configuration/verifyPMMSettingsPageFunctionality_test.js +++ b/tests/configuration/verifyPMMSettingsPageFunctionality_test.js @@ -347,6 +347,7 @@ Scenario( I.assertTrue(publicAddressValue.length > 0, 'Expected the Public Address Input Field to be not empty!'); pmmSettingsPage.applyChanges(); + // Remove wait after https://perconadev.atlassian.net/browse/PMM-13340 is fixed I.wait(5); I.refreshPage(); await pmmSettingsPage.waitForPmmSettingsPageLoaded(); From cf27be5b8463b06b9a5e8537d80db796a867e58d Mon Sep 17 00:00:00 2001 From: yurkovychv Date: Tue, 3 Sep 2024 11:53:27 +0300 Subject: [PATCH 3/3] PMM-7 add wait for server logs tests --- tests/serverLogs_test.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/serverLogs_test.js b/tests/serverLogs_test.js index 27ccf650f..6a55ded04 100644 --- a/tests/serverLogs_test.js +++ b/tests/serverLogs_test.js @@ -7,11 +7,13 @@ const filename = 'logs.zip'; const fileNameToCheck = 'pmm-managed.log'; const baseUrl = codeceptjsConfig.config.helpers.Playwright.url; -BeforeSuite(async ({ locationsAPI }) => { +BeforeSuite(async ({ I, locationsAPI }) => { // Simple request to generate > 50k lines in logs for (let i = 0; i < 13000; i++) { await locationsAPI.getLocationsList(); } + + I.wait(15); }); // @settings-fb tag added in order to execute these tests on FB