Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the custom migration logic from all runtimes #454

Open
ebma opened this issue Apr 18, 2024 · 6 comments · May be fixed by #498
Open

Remove the custom migration logic from all runtimes #454

ebma opened this issue Apr 18, 2024 · 6 comments · May be fixed by #498
Assignees

Comments

@ebma
Copy link
Member

ebma commented Apr 18, 2024

As part of our efforts to upgrade the dependencies to v0.9.42, we added custom migration logic to all runtimes. Now that these changes are rolled out and all the migrations applied, we can remove that extra logic again.

TODO

  • Remove the CustomOnRumtimeUpgrade implementations again
  • Remove the customized dependencies. We had to create forks of some projects in order to be able to modify their migration logic. We can delete those forks again and switch back to the 'official'/upstream dependency versions.
@ebma
Copy link
Member Author

ebma commented Apr 18, 2024

@pendulum-chain/product this is more of a chore but nice-to-have and low effort. We can clean up some unnecessary code and repositories with this.

@prayagd
Copy link
Collaborator

prayagd commented Apr 25, 2024

@gianfra-t
Copy link
Contributor

I think we can reuse this ticket and remove the custom migration logic after the 1.1.0 upgrade is completed. Otherwise we would need to re-add them soon.

@ebma
Copy link
Member Author

ebma commented Jul 8, 2024

Right, let's do that. I added the ticket as a blocker to the Zenhub dependencies.

@b-yap b-yap assigned b-yap and unassigned b-yap Jul 16, 2024
@vadaynujra
Copy link

@ebma is this possible to be worked on now, or only after the upgrade on Pendulum?

@gianfra-t
Copy link
Contributor

@vadaynujra only once we have updated the runtimes we can remove this extra code. We left this ticket also as a reminder to remove the extra logic after the runtime upgrade that bumps to 1.1.0 is enacted on all runtimes.

In any case, this is not blocking anything.

@b-yap b-yap self-assigned this Oct 3, 2024
@b-yap b-yap linked a pull request Oct 4, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants