Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/nextcloud28 #151

Merged
merged 10 commits into from
Feb 13, 2024
Merged

Feature/nextcloud28 #151

merged 10 commits into from
Feb 13, 2024

Conversation

ylebre
Copy link
Member

@ylebre ylebre commented Feb 7, 2024

Fixes for NC28 compatibility

@ylebre ylebre marked this pull request as draft February 7, 2024 15:10
@ylebre ylebre marked this pull request as ready for review February 7, 2024 16:11
solid/img/app.svg Outdated Show resolved Hide resolved
@@ -439,7 +439,7 @@ private function respond($response) {
$policy->addAllowedFontDomain("*");
$policy->addAllowedConnectDomain("*");
$policy->allowInlineStyle(true);
$policy->allowInlineScript(true);
// $policy->allowInlineScript(true); - removed, this function no longer exists in NC28
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be documented (somewhere?) that allowedScriptDomains or evalScriptAllowed should now be used to enable the script-src policy?

Copy link
Member

@Potherca Potherca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing blocking found.

@ylebre ylebre merged commit eb2ae68 into main Feb 13, 2024
30 of 32 checks passed
@ylebre ylebre deleted the feature/nextcloud28 branch February 13, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants