Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow replacing output and inserting new outputs #69

Closed
Kixunil opened this issue May 10, 2023 · 4 comments
Closed

Allow replacing output and inserting new outputs #69

Kixunil opened this issue May 10, 2023 · 4 comments
Labels
api enhancement New feature or request receive receiving payjoin
Milestone
payjoin-0.21.0

Comments

@Kixunil
Copy link
Contributor

Kixunil commented May 10, 2023

This is needed for fancy things like batching or efficient LN channel opening...
@DanGould
Copy link
Contributor

This is supported in PayjoinProposal. What do you have in mind that is not yet possible?

@DanGould DanGould added the enhancement New feature or request label May 11, 2023
@Kixunil
Copy link
Contributor Author

Kixunil commented May 11, 2023 •
edited
Loading

Those handle adding inputs, not outputs. I missed substitute_output_address but it really should be substitute_script_pubkey to allow LN channels. Also it'd be great to have methods to reasonably modify values - e.g. giving a discount to the payer.

@DanGould DanGould added the receive receiving payjoin label May 27, 2023
@DanGould DanGould mentioned this issue Jul 23, 2023
Closed
@DanGould DanGould added this to the 1.0 milestone Jul 31, 2023
@DanGould DanGould added the api label Jul 31, 2023
@jbesraa
Copy link
Collaborator

jbesraa commented May 8, 2024 •
edited
Loading

Added this ef8c7ec as part of this pr #233

@DanGould DanGould mentioned this issue May 8, 2024
Closed
@DanGould DanGould mentioned this issue Jun 3, 2024
Merged
@DanGould DanGould mentioned this issue Jul 8, 2024
Closed
@DanGould DanGould modified the milestones: payjoin-1.0, payjoin-0.20.0 Jul 30, 2024
@DanGould
Copy link
Contributor

closed by #313

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api enhancement New feature or request receive receiving payjoin
Projects
Payjoin Roadmap 📝
Status: Done
Milestone
payjoin-0.21.0
Development

No branches or pull requests
3 participants
@Kixunil @DanGould @jbesraa