Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To-do topics #2

Open
pawelwiejkut opened this issue Apr 6, 2021 · 11 comments
Open

To-do topics #2

pawelwiejkut opened this issue Apr 6, 2021 · 11 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@pawelwiejkut
Copy link
Owner

pawelwiejkut commented Apr 6, 2021

If you want to help with some topic, please create a separate GitHub issue. This one is only for discussing new features.

Major:

  • Coding for Compare solutions
  • Coding for Performance test
  • BW4Hana compatibility check
  • AMDP Support
  • Test class
@pawelwiejkut pawelwiejkut added enhancement New feature or request help wanted Extra attention is needed labels Apr 6, 2021
@pawelwiejkut pawelwiejkut self-assigned this Apr 6, 2021
@reyemsaibot
Copy link

I try to understand why my issue #7 is raised, so I used parts of your code to create an own solution. If it works, and I find the issue, I would share it with you, so we can work on the open topics.

@pawelwiejkut
Copy link
Owner Author

I think that in general this function module for comparing tables is bad idea - so I will probably replace this part. Regarding help - of course, if you have some new functions, improvements, then feel free to submit a pull request :)

@reyemsaibot
Copy link

Why do you think it is a bad idea? Somehow you have to compare the results to see if it matches your expectation or if the new development will be faster. I have a similar comparing function to check transformations between different systems. It works, or do you have another idea to compare the results?

@pawelwiejkut
Copy link
Owner Author

In general usage of this FM provide a couple of issues. Firstly it checks also the type of the fields, which also lead to dump (or provide that the results don't match I don't remember now). Secondly - for now, there is no feedback on what value exaclty is wrong. Definitely, I want to display a table for users with information (i.e. colours) which value is good, and which one is not good. Not only do a general check.

The big challenge is I want to keep this solution for a single copy-paste installation like abapgit, so I don't know can simple ALV in popup handle this. If not then maybe an HTML table is a solution 🤔

@reyemsaibot
Copy link

In my transformation checker, I mark false or wrong entries with a red background. You can see it here on the short video https://youtu.be/OMXl3DjfN7g maybe this is a solution?

@pawelwiejkut
Copy link
Owner Author

pawelwiejkut commented Oct 11, 2021 via email

@reyemsaibot
Copy link

At the moment I am trying to make the solution flexible enough to dynamic tables. The problem is at the moment the comparing of the tables. If I have an idea that works I will share it on GitHub.

@pawelwiejkut
Copy link
Owner Author

pawelwiejkut commented Oct 11, 2021 via email

@reyemsaibot
Copy link

I have now a table comparison created which is in my opinion flexible enough. I upload the source code later, the readme is already filled https://github.com/reyemsaibot/table_compare

@pawelwiejkut
Copy link
Owner Author

pawelwiejkut commented Oct 14, 2021 via email

@reyemsaibot
Copy link

If you need help to test something let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants