Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPIKE] Resolve Passport-sdk-verifier spruce/didkit issue #675

Open
farque65 opened this issue Nov 1, 2022 · 8 comments
Open

[SPIKE] Resolve Passport-sdk-verifier spruce/didkit issue #675

farque65 opened this issue Nov 1, 2022 · 8 comments
Assignees

Comments

@farque65
Copy link
Contributor

farque65 commented Nov 1, 2022

This error was highlighted in the following passport-sdk issue passportxyz/passport-sdk#23

Potential Resolutions:

  • Build a node version of the passport-sdk-verifier and passport-sdk-scorer using the @spruceid/didkit-wasm-node module
  • Discuss the issue with the Spruce Id team to see if they will create a compatible version of the @spruceid/didkit-wasm module
@farque65 farque65 self-assigned this Nov 1, 2022
@farque65
Copy link
Contributor Author

farque65 commented Nov 1, 2022

After discussing the issue with the Spruce Id team I received the following update:

I published version 0.3.0-alpha0 which has both Node.js and Bundler packages bundled. I couldn't quite test it because of Cannot find module '@gitcoinco/passport-sdk-reader'

I will import the new module into the passport-sdk-verifier and see if it resolves the issue

@farque65 farque65 changed the title [Research] Resolve Passport-sdk-verifier spruce/didkit issue [SPIKE] Resolve Passport-sdk-verifier spruce/didkit issue Nov 1, 2022
@baptistegreve
Copy link

Hey @farque65! Have you been able to fix this for the passport-sdk-verifier package?

@farque65
Copy link
Contributor Author

farque65 commented Nov 3, 2022

There is a fix coming soon that will be released.

@baptistegreve
Copy link

Great! Do you have any ETA for this @farque65? I would like to add the verifier to our indexing system early next week :) Thanks!

@farque65
Copy link
Contributor Author

farque65 commented Nov 3, 2022

Great! Do you have any ETA for this @farque65? I would like to add the verifier to our indexing system early next week :) Thanks!

This sounds awesome. We are definitely looking forward to it. You can expect the new module before the end of the week.

A work around in the mean time is to use the verifier file (https://github.com/gitcoinco/passport-sdk/blob/main/packages/verifier/src/verifier.ts) then use @spruceid/didkit-wasm-node instead of the current @spruceid/didkit-wasm module.

@baptistegreve
Copy link

before the end of the week.

That's great, thanks!

@baptistegreve
Copy link

hey @farque65! any update on this?

@farque65
Copy link
Contributor Author

There has been a recent update published for the verifier and scorer sdks

@gitcoinco/[email protected]
@gitcoinco/[email protected]

There are some more changes coming to the reader and this will lead to further updates on the verifier and scorer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants