Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publish release script is broken #1618

Open
niklasad1 opened this issue May 28, 2024 · 4 comments
Open

publish release script is broken #1618

niklasad1 opened this issue May 28, 2024 · 4 comments

Comments

@niklasad1
Copy link
Member

niklasad1 commented May 28, 2024

The publish release script: https://github.com/paritytech/subxt/blob/master/scripts/publish.sh is both broken and outdated.

  1. It needs to be updated to support workspace dependencies
  2. It needs to be updated for the new crates added such as core, light-client and signer
  3. Because core has the signer as a dev-dependency it needs to be removed otherwise it can't be released.

Alternatively, just remove it

@jsdw
Copy link
Collaborator

jsdw commented May 28, 2024

oh I forgot we even had such a script and just copy the command in the RELEASING doc. We def don't need a bunch of the ocmplexity there (ie cargo now waits for the crate itself anyway) so I'd be game for removing or just simplifying it! (perhaps it could handle using cagro hack or whatever if we can't otherwise resolve that cyclic dev dependency issue

@niklasad1
Copy link
Member Author

niklasad1 commented May 28, 2024

Unfortunately cargo hack didn't work without hacks.

➜ core (master) ✗ cargo hack publish --allow-dirty --remove-dev-deps --dry-run
info: running `cargo publish --allow-dirty --dry-run` on subxt-core (1/1)
error: failed to load manifest for workspace member `/home/niklasad1/Github/subxt/testing/integration-tests`
referenced by workspace at `/home/niklasad1/Github/subxt/Cargo.toml`

Caused by:
  failed to parse manifest at `/home/niklasad1/Github/subxt/testing/integration-tests/Cargo.toml`

Caused by:
  feature `unstable-light-client` includes `subxt/unstable-light-client`, but `subxt` is not a dependency

@lexnv
Copy link
Collaborator

lexnv commented May 28, 2024

I believe it would be easier to copy paste the release command from the RELEASING doc. Then, we won't have to maintain anymore the release script, just the doc command. What do you guys think?

@niklasad1
Copy link
Member Author

niklasad1 commented May 28, 2024

Yes, but there is the caveat with the cyclic dependencies for subxt-core such that we can't release it without comment out the dev-dependecies.

With that said, I'm in favor of removing it, since the what we have in the RELEASE doc is sufficient but we could explain the core stuff...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants