Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename fields in contracts metadata #50

Open
smiasojed opened this issue Sep 18, 2024 · 4 comments
Open

Rename fields in contracts metadata #50

smiasojed opened this issue Sep 18, 2024 · 4 comments
Assignees

Comments

@smiasojed
Copy link
Collaborator

In the metadata we provide following informations:

						"solc_zkvm_edition": null,
						"zk_version": "0.1.0"

I suppose we should change it to revive_version/resolc_version

@athei
Copy link
Member

athei commented Sep 18, 2024

Isn't resolc= revive? So it should be solc_version and revive_version?

@smiasojed
Copy link
Collaborator Author

it is the same, I am not sure which convention we should follow resolc or revive.
solc has its own metadata:
"solc_metadata": "{\"compiler\":{\"version\":\"0.8.26+commit.8a97fa7a\"},...}

@xermicus xermicus self-assigned this Sep 19, 2024
@xermicus
Copy link
Member

revive is the project and workspace name and resolc the binary name of the Solidity frontend (matter labs names them in a similar fasion: "era compiler" is the overall compiler project name and zksolc the Solidity frontend binary). We could add more frontends if needed, for example Vyper, or potentially some other binaries, which would still belong and live in revive.

We should rename those fields too:
zk_version -> revive_version
solc_zkvm_edition -> pallet_revive_version

@xermicus
Copy link
Member

Isn't resolc= revive? So it should be solc_version and revive_version?

As for the version, this should hold up. E.g. the revive version will dictate the resolc version anyways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants