Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not supported evm.bytecode and evm.assembly options in compiler configuration #39

Open
smiasojed opened this issue Sep 2, 2024 · 2 comments
Assignees

Comments

@smiasojed
Copy link
Collaborator

smiasojed commented Sep 2, 2024

Although the tool claims that it does not support evm.bytecode and evm.assembly, it still returns it as part of the compilation output.

Used compiler config:

{
	"language": "Solidity",
	"settings": {
		"optimizer": {
			"enabled": true,
			"runs": 200
		},
		"outputSelection": {
			"*": {
			"": ["ast"],
			"*": ["abi", "metadata", "devdoc", "userdoc", "storageLayout", "evm.bytecode", "evm.legacyAssembly", "evm.deployedBytecode", "evm.methodIdentifiers", "evm.assembly"]
			}
		}
	}
}

It is expected that tool accepts evm.bytecode and evm.assembly

@smiasojed smiasojed changed the title Not supported evm.bytecode option in compiler configuration Not supported evm.bytecode and evm.assembly option in compiler configuration Sep 4, 2024
@smiasojed smiasojed changed the title Not supported evm.bytecode and evm.assembly option in compiler configuration Not supported evm.bytecode and evm.assembly options in compiler configuration Sep 4, 2024
@smiasojed
Copy link
Collaborator Author

evm.gasEstimates is also not supported

@xermicus
Copy link
Member

xermicus commented Oct 4, 2024

Stemming from an internal discussion:

  • Provide what was requested; however
  • Provide default values for incompatible data (if requested)

We substitute any byte-code incompatible fields with empty objects. This won't crash any tools relying on it, they can still request it but will get a zero or empty value. Which they can do nothing with so we should be save. Also this will make remix happy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants