Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile window hangs if browser is unable to reach the Cloud Compiler #631

Open
zfi opened this issue Jun 25, 2021 · 0 comments
Open

Compile window hangs if browser is unable to reach the Cloud Compiler #631

zfi opened this issue Jun 25, 2021 · 0 comments

Comments

@zfi
Copy link
Contributor

zfi commented Jun 25, 2021

The Compile dialog window posts an initial "Compile" message but does not react when the application is unable to reach the Cloud Compiler container. The console log does indicate that a failure has been detected:

16:21:07.418 Compiler error: Failed to fetch
instrument.js:109 16:21:07.420 (PTC) Error while compiling
instrument.js:109 16:21:07.420 (PTC) Message: Cannot read property 'success' of undefined

The UI should provide some indication that the compile failed due to a connectivity issue and the the compilation itself has not been performed.

ideally, the compile button should be inactive if the Cloud Compiler is unreachable. Employing a heartbeat could generate significant traffic if there are hundreds of users online simultaneously. Perhaps a better option is to ping the Cloud Compiler after the "Compile" button is clicked and the Compile dialog is opened, but before the first "Compile" output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant