Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PayloadBuilder Implementation that supports two types of builders #10438

Open
Tracked by #10435
mattsse opened this issue Aug 22, 2024 · 5 comments · May be fixed by #11004
Open
Tracked by #10435

Add PayloadBuilder Implementation that supports two types of builders #10438

mattsse opened this issue Aug 22, 2024 · 5 comments · May be fixed by #11004
Labels
A-block-building Related to block building C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started

Comments

@mattsse
Copy link
Collaborator

mattsse commented Aug 22, 2024 •
edited
Loading

The PayloadBuilder trait defines the interface for a basic payloadbuilder:

reth/crates/payload/basic/src/lib.rs

Line 792 in a0a2f35

pub trait PayloadBuilder<Pool, Client>: Send + Sync + Clone {

it would be nice if we would have a type that supports two kinds of builders:

struct PayloadBuilderStack<L,R> {}

this way we could easily integrate multiple builder types, e.g. rpc pending block and regular CL
@mattsse mattsse mentioned this issue Aug 22, 2024
Closed
@mattsse mattsse added C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started A-block-building Related to block building labels Aug 22, 2024
@tolu0x
Copy link

tolu0x commented Aug 22, 2024

@mattsse assign me

@garwahl
Copy link
Contributor

garwahl commented Aug 28, 2024

Hey @tolu0x are you still working on this? Happy to pick this up as I'm doing some work with PayloadBuilder at the moment

@tolu0x
Copy link

tolu0x commented Aug 28, 2024

Hey @garwahl, i've not been able to complete my implementation due to my exams. If you can take it on, i'd be delighted to see your solution. LGTM

@nkysg
Copy link
Contributor

nkysg commented Aug 30, 2024

@garwahl first. If no one try, I want to try.

@mattsse mattsse assigned nkysg and unassigned tolu0x Aug 30, 2024
@nkysg
Copy link
Contributor

nkysg commented Aug 31, 2024

The PayloadBuilder trait defines the interface for a basic payloadbuilder:

reth/crates/payload/basic/src/lib.rs

Line 792 in a0a2f35

pub trait PayloadBuilder<Pool, Client>: Send + Sync + Clone {

it would be nice if we would have a type that supports two kinds of builders:

struct PayloadBuilderStack<L,R> {}

this way we could easily integrate multiple builder types, e.g. rpc pending block and regular CL

I'm not really geting about two kinds of builders. I just see EthereumPayloadBuilder and OptimismPayloadBuilder. Is it right @mattsse ?

@aroralanuk aroralanuk linked a pull request Sep 18, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-block-building Related to block building C-enhancement New feature or request D-good-first-issue Nice and easy! A great choice to get started
Projects
Reth Tracker
Status: Todo
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(payload): add support for multiple payload builders in BasicPayloadJobGenerator aroralanuk/reth
4 participants
@nkysg @garwahl @mattsse @tolu0x