RPC Executor improvements

[Rjected]

debug_executionWitness currently needs to output all state required to execute the given block. The endpoint currently does not work for optimism because it needs to use the optimism executor, and the eth mainnet system calls may be different from optimism. It also needs to retain more execution-related information than is desired for the vanilla executor.

The debug_executionWitness endpoint

The endpoint needs to return the following information:

• all state that was accessed or changed during block execution
  • including system calls and transactions
• all code loaded during execution
• merkle proofs for the state accessed / changed during block execution

We need to leave the current executor as-is, so we don't do more than needed during regular block processing.

A new executor

So, we now have the BlockAccessListExecutor, which implements the Executor trait:

reth/crates/ethereum/evm/src/execute.rs

Line 392 in 9760319

impl<EvmConfig, DB> Executor<DB> for BlockAccessListExecutor<EvmConfig, DB>

This is a new executor that retains the accessed state in the BundleState of the BlockExecutionOutput. There is also one for optimism. This separate executor meets all requirements for the endpoint, but we still need to make this executor accessible to the RPC endpoint.

Executors in RPC

We currently have the BlockExecutorProvider, which provides multiple types of executors for RPC to use:

reth/crates/evm/src/execute.rs

Lines 110 to 123 in 9760319

	type Executor<DB: Database<Error: Into<ProviderError> + Display>>: for<'a> Executor<
	DB,
	Input<'a> = BlockExecutionInput<'a, BlockWithSenders>,
	Output = BlockExecutionOutput<Receipt>,
	Error = BlockExecutionError,
	>;
	/// An executor that can execute a batch of blocks given a database.
	type BatchExecutor<DB: Database<Error: Into<ProviderError> + Display>>: for<'a> BatchExecutor<
	DB,
	Input<'a> = BlockExecutionInput<'a, BlockWithSenders>,
	Output = ExecutionOutcome,
	Error = BlockExecutionError,
	>;

This PR includes a third type of executor to include in the BlockExecutorProvider trait: #10868

We can either:

• pursue this direction further, or
• change how we get executors for rpc somehow

cc @mattsse

[malik672]

debug_executionWitness currently needs to output all state required to execute the given block. The endpoint currently does not work for optimism because it needs to use the optimism executor, and the eth mainnet system calls may be different from optimism. It also needs to retain more execution-related information than is desired for the vanilla executor.

The debug_executionWitness endpoint

The endpoint needs to return the following information:

• all state that was accessed or changed during block execution

  • including system calls and transactions

• all code loaded during execution

• merkle proofs for the state accessed / changed during block execution

We need to leave the current executor as-is, so we don't do more than needed during regular block processing.

A new executor

So, we now have the BlockAccessListExecutor, which implements the Executor trait:

reth/crates/ethereum/evm/src/execute.rs

Line 392 in 9760319

impl<EvmConfig, DB> Executor<DB> for BlockAccessListExecutor<EvmConfig, DB>

This is a new executor that retains the accessed state in the BundleState of the BlockExecutionOutput. There is also one for optimism. This separate executor meets all requirements for the endpoint, but we still need to make this executor accessible to the RPC endpoint.

Executors in RPC

We currently have the BlockExecutorProvider, which provides multiple types of executors for RPC to use:

reth/crates/evm/src/execute.rs

Lines 110 to 123 in 9760319

	type Executor<DB: Database<Error: Into<ProviderError> + Display>>: for<'a> Executor<
	DB,
	Input<'a> = BlockExecutionInput<'a, BlockWithSenders>,
	Output = BlockExecutionOutput<Receipt>,
	Error = BlockExecutionError,
	>;
	/// An executor that can execute a batch of blocks given a database.
	type BatchExecutor<DB: Database<Error: Into<ProviderError> + Display>>: for<'a> BatchExecutor<
	DB,
	Input<'a> = BlockExecutionInput<'a, BlockWithSenders>,
	Output = ExecutionOutcome,
	Error = BlockExecutionError,
	>;

This PR includes a third type of executor to include in the BlockExecutorProvider trait: #10868

We can either:

• pursue this direction further, or
• change how we get executors for rpc somehow

cc @mattsse

I'm not sure but I think it should be made custom, would solve the compatibility issue easily