From 4d7dd63cf52e1a59b1d12bef19f08b8709fceed4 Mon Sep 17 00:00:00 2001 From: Sorin Carbunaru Date: Mon, 30 Sep 2024 16:43:43 +0300 Subject: [PATCH] EXM-53634: changed to info message + reused code --- .../oxygenxml/git/OutdatedBranchChecker.java | 37 +++++++++++-------- 1 file changed, 21 insertions(+), 16 deletions(-) diff --git a/src/main/java/com/oxygenxml/git/OutdatedBranchChecker.java b/src/main/java/com/oxygenxml/git/OutdatedBranchChecker.java index 9c9b8188..ed00c2d8 100644 --- a/src/main/java/com/oxygenxml/git/OutdatedBranchChecker.java +++ b/src/main/java/com/oxygenxml/git/OutdatedBranchChecker.java @@ -133,14 +133,10 @@ private static synchronized void checkForOutdatedBranches() { SwingUtilities.invokeLater(() -> { if (branchesAndTooltips.containsKey(currentBranchName) && branchesAndTooltips.size() == 1) { - MessagePresenterProvider.getBuilder(i18n.getTranslation(Tags.OUTDATED_BRANCHES_DETECTED), DialogType.INFO) - .setMessage( - MessageFormat.format(i18n.getTranslation(Tags.OUTDATED_CURRENT_BRANCH), currentBranchName) - + "\n\n" - + MessageFormat.format(i18n.getTranslation(Tags.STASH_IMPORTANT_CHANGES), currentBranchName)) - .setOkButtonVisible(false) - .setCancelButtonName(i18n.getTranslation(Tags.CLOSE)) - .buildAndShow(); + showCurrentBranchRelatedMessage( + MessageFormat.format(i18n.getTranslation(Tags.OUTDATED_CURRENT_BRANCH), currentBranchName) + + "\n\n" + + MessageFormat.format(i18n.getTranslation(Tags.STASH_IMPORTANT_CHANGES), currentBranchName)); } else { showOutdatedBranchesDialog(branchesAndTooltips, currentBranchName); } @@ -209,15 +205,24 @@ private static void tryDeleteBranches( GitOperationScheduler.getInstance().schedule(deleteBranchesTask); if (shouldDeleteCurrentBranch) { - MessagePresenterProvider.getBuilder(i18n.getTranslation(Tags.OUTDATED_BRANCHES_DETECTED), DialogType.ERROR) - .setMessage( - MessageFormat.format(i18n.getTranslation(Tags.CANNOT_DELETE_CURRENT_BRANCH), currentBranchName) - + "\n\n" - + MessageFormat.format(i18n.getTranslation(Tags.STASH_IMPORTANT_CHANGES), currentBranchName)) - .setOkButtonVisible(false) - .setCancelButtonName(i18n.getTranslation(Tags.CLOSE)) - .buildAndShow(); + showCurrentBranchRelatedMessage( + MessageFormat.format(i18n.getTranslation(Tags.CANNOT_DELETE_CURRENT_BRANCH), currentBranchName) + + "\n\n" + + MessageFormat.format(i18n.getTranslation(Tags.STASH_IMPORTANT_CHANGES), currentBranchName)); } } + /** + * Show a message related to the fact than the current branch cannot be deleted. + * + * @param message The message to show. + */ + private static void showCurrentBranchRelatedMessage(String message) { + MessagePresenterProvider.getBuilder(i18n.getTranslation(Tags.OUTDATED_BRANCHES_DETECTED), DialogType.INFO) + .setMessage(message) + .setOkButtonVisible(false) + .setCancelButtonName(i18n.getTranslation(Tags.CLOSE)) + .buildAndShow(); + } + }