Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dinosaur wants to build from source without a signing key... #378

Open
gl-yziquel opened this issue May 29, 2024 · 3 comments
Open

Dinosaur wants to build from source without a signing key... #378

gl-yziquel opened this issue May 29, 2024 · 3 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@gl-yziquel
Copy link
Contributor

gl-yziquel commented May 29, 2024

Hi.

I'd like to build from source. A sort of personal hygiene.

I noticed the following in gem/rb_sys.gemspec:

spec.signing_key = File.expand_path("~/.ssh/gem-private_key.pem") if $0.end_with?("gem")

I could always circumvent that with a bit of hackery, but... I would greatly appreciate if there could be an easy way to build the gemfolder hierarchy with a simple command like bundle exec rake build.

Could it be possible to either consider a NO_SIGN environment variable or some explicit instructions as to how best to do it without the hassle of either brittle hackery or the overhead of creating a key in a folder location that I consider my personal private space ?

Best.

P.S.: For now, using sed -i.bak '/spec.signing_key/s/^/#/' rb_sys.gemspec.

@ianks
Copy link
Collaborator

ianks commented May 29, 2024

I'd accept a PR which removes the check with RUBYGEMS_FORCE_DISABLE_GEM_SIGNING=true env var check

@ianks
Copy link
Collaborator

ianks commented May 30, 2024

Done. Do you need me to cut a new release or is git sha good enough?

@gl-yziquel
Copy link
Contributor Author

The git sha is good enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants