Error handling #43 : migration from fatal to println #62
Conversation
- remove fmt to log package for printing issue
There was a problem hiding this comment.
Thanks for the PR @OgmaJ 🎆 . I have requested some changes, please look into it.
| @@ -1,5 +1,6 @@ | |||
| logs | |||
| .exe | |||
| .idea | |||
| ## Set Mongo DB | ||
| 1. The configuration of your mongo db should be in : mongodb://localhost:27017 | ||
|
|
There was a problem hiding this comment.
Thanks for pointing this out. Proper setup instructions are already listed in https://github.com/osdc/bots/blob/master/CONTRIBUTING.md. We will update the README as part of #48 so it's not needed in this PR :)
| "log" | ||
| "math/rand" | ||
| "os" | ||
| "strconv" | ||
| "time" |
There was a problem hiding this comment.
Can you revert this? The existing order seemed to be better :)
| @@ -47,7 +45,7 @@ func tweet() { | |||
|
|
|||
| demux := twitter.NewSwitchDemux() | |||
| demux.Tweet = func(tweet *twitter.Tweet) { | |||
| fmt.Println(tweet.IDStr) | |||
| log.Println(tweet.IDStr) | |||
There was a problem hiding this comment.
log prints out to stderr but this is not needed in stderr so the use of fmt is fine.
| log.Println(tweet.IDStr) | |
| fmt.Println(tweet.IDStr) |
| @@ -70,7 +68,7 @@ func xkcd(ID int64) { | |||
| for _, link := range links { | |||
| imglink := link.Attrs()["src"] | |||
| fullurl := "https:" + imglink | |||
| fmt.Println(fullurl) | |||
| log.Println(fullurl) | |||
There was a problem hiding this comment.
| log.Println(fullurl) | |
| fmt.Println(fullurl) |
| @@ -192,7 +190,7 @@ func main() { | |||
| log.Fatal(err) | |||
| } | |||
|
|
|||
| fmt.Println("Connected to MongoDB!") | |||
| log.Println("Connected to MongoDB!") | |||
There was a problem hiding this comment.
| log.Println("Connected to MongoDB!") | |
| fmt.Println("Connected to MongoDB!") |
| @@ -167,7 +165,7 @@ func main() { | |||
| var err error | |||
| bot, err = tbot.NewBotAPI(os.Getenv("TELEGRAM_TOKEN")) | |||
| if err != nil { | |||
| fmt.Println("error in auth") | |||
| log.Println("error in auth") | |||
There was a problem hiding this comment.
It's justified here since we are logging the error 👍
|
|
||
| func sendErrorToChan(err error, ID int64, errorTxt string) { | ||
| log.Print(err) | ||
| bot.Send(tbot.NewMessage(ID, errorTxt)) | ||
| } |
There was a problem hiding this comment.
declare this in main.go then it should be accessible across all the files. So you can call the function in other functions not part of meetups too.
| log.Println(err) | ||
| bot.Send(tbot.NewMessage(ID, "Error appears, please try again later")) | ||
| return |
There was a problem hiding this comment.
Refer to the comment on sendErrorToChan in meetups.go
Fixes #43