Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update parent child components #817

Merged
merged 4 commits into from
Feb 28, 2024
Merged

Conversation

mlmoravek
Copy link
Member

@mlmoravek mlmoravek commented Feb 28, 2024

Proposed Changes

  • refactor dropdown to useProviderParent & useProviderChild instead of custom provide/inject
  • refactor steps component activeValue
  • refactor tabs component activeValue
  • refactor useVModelBinding to defineModel

Copy link

netlify bot commented Feb 28, 2024

Deploy Preview for oruga-documentation-preview ready!

Name Link
🔨 Latest commit f39714f
🔍 Latest deploy log https://app.netlify.com/sites/oruga-documentation-preview/deploys/65def0a4c72ef100082178f8
😎 Deploy Preview https://deploy-preview-817--oruga-documentation-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Feb 28, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 21 lines in your changes are missing coverage. Please review.

Project coverage is 56.71%. Comparing base (27fe3b5) to head (f39714f).
Report is 2 commits behind head on develop.

Files Patch % Lines
packages/oruga/src/utils/helpers.ts 14.28% 18 Missing ⚠️
...ges/oruga/src/components/dropdown/DropdownItem.vue 66.66% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #817      +/-   ##
===========================================
+ Coverage    54.66%   56.71%   +2.05%     
===========================================
  Files           31       30       -1     
  Lines         1500     1511      +11     
  Branches       536      544       +8     
===========================================
+ Hits           820      857      +37     
+ Misses         680      654      -26     
Flag Coverage Δ
oruga-next 56.71% <40.00%> (+2.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mlmoravek mlmoravek merged commit 484cfe8 into develop Feb 28, 2024
7 of 9 checks passed
@mlmoravek mlmoravek deleted the refactor-parent-child branch February 28, 2024 08:56
@mlmoravek mlmoravek added the refactoring This involves some refactoring of existing code. label Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring This involves some refactoring of existing code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant