Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull Requests #29

Open
codesplode opened this issue May 20, 2019 · 2 comments
Open

Pull Requests #29

codesplode opened this issue May 20, 2019 · 2 comments

Comments

@codesplode
Copy link
Contributor

I took some time to separate and organize into pull requests some of my team's work on Squash that we thought you might like. We hope these features are useful and are happy to answer any questions where you have them.

We closed a previous issue regarding generalizing FunctionExpression implementations as our work already includes this.

Thank you

@codesplode
Copy link
Contributor Author

We have more changes to contribute, including allowing nullable columns in LIKE expressions, and more work on the MySQL data math functions, among others, but the work is starting to stack up as some of the improvements depends on others still waiting to be merged.

For the time being, I'll try to keep some branches to make it easy to contribute when the project is ready for them. Please let me know then so I can help submit the changes correctly for you and answer any questions.

@codesplode
Copy link
Contributor Author

Hi @orangy ,

As an update, we've been adding even more features to squash and have column in (subquery) support, isNull() / isNotNull() support, numeric column casting (using int column to compare to long), etc. but I understand if you are too busy to accept these changes right now. With that in mind, I won't pile up the pull requests even more haha. If there is anything I can do to help the project further, please let me know. We are happy to support it while you are on the noble job of furthering the Kotlin language.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant