Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation updates and version change in Makefile #455

Merged
merged 1 commit into from
Feb 29, 2024
Merged

Documentation updates and version change in Makefile #455

merged 1 commit into from
Feb 29, 2024

Conversation

l-technicore
Copy link
Member

@l-technicore l-technicore commented Feb 16, 2024 •
edited
Loading

Changes:

  • Version update in Makefile
  • Load Balancer Annotations document update

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Feb 16, 2024
@coveralls
Copy link

coveralls commented Feb 16, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8095484652

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage remained the same at 30.875%
Files with Coverage Reduction New Missed Lines %
pkg/cloudprovider/providers/oci/load_balancer.go 1 26.83%
Totals Coverage Status
Change from base Build 8047525895: 0.0%
Covered Lines: 3923
Relevant Lines: 12706
💛 - Coveralls

@l-technicore l-technicore self-assigned this Feb 16, 2024
@l-technicore l-technicore changed the title Version update in Makefile Documentation updates and version change in Makefile Feb 20, 2024
AkarshES
AkarshES previously approved these changes Feb 26, 2024
View reviewed changes
AkarshES
AkarshES previously approved these changes Feb 29, 2024
View reviewed changes
@l-technicore l-technicore merged commit cd3c0b6 into oracle:master Feb 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pranavsriram8 pranavsriram8 pranavsriram8 approved these changes

@rohitChaware rohitChaware rohitChaware approved these changes

@YashasG98 YashasG98 YashasG98 approved these changes

@mrunalpagnis mrunalpagnis Awaiting requested review from mrunalpagnis

@AkarshES AkarshES Awaiting requested review from AkarshES

Assignees

@l-technicore l-technicore

Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@l-technicore @coveralls @AkarshES @pranavsriram8 @rohitChaware @YashasG98