Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension v1.5.1 corrupts credential file #767

Closed
gabrielgortabns opened this issue Nov 2, 2023 · 5 comments
Closed

Extension v1.5.1 corrupts credential file #767

gabrielgortabns opened this issue Nov 2, 2023 · 5 comments
Assignees

Comments

@gabrielgortabns
Copy link

gabrielgortabns commented Nov 2, 2023

Select the SuiteCloud tool where you encountered the issue

SuiteCloud Extension for VSCode

Version of the SuiteCloud Tool

1.5.1

Operating system

Windows 11

Node Version / VSCode Version

Node: v18.15.0, VSCode: v1.83.1

JAVA Version

java 17.0.7+8-LTS-224 or newer

Bug description

./.suitecloud-sdk/credentials gets corrupted with newer extension version. Tested with 1.4.2 and Java 17.0.7, everything works fine, but if Java or Extension is newer version, it corrupts the credentials file.

Steps To Reproduce

  1. execute suitecloud account:setup -i
  2. errors shows that ./.suitecloud-sdk/credentials is corrupted

Actual Output

No response

Expected Output

No response

Anything else?

related: #716

@gabrielgortabns gabrielgortabns changed the title Extension 1.5.2 corrupts credential file Extension v1.5.2 corrupts credential file Nov 2, 2023
@antoniofruci
Copy link
Member

Hello @GabrielGorta,
latest published version version is 1.5.1
Can you please confirm what's the version you are facing the issue with?

@antoniofruci antoniofruci self-assigned this Nov 2, 2023
@gabrielgortabns
Copy link
Author

gabrielgortabns commented Nov 6, 2023

oh, sorry, right, it was version 1.5.1, I misstyped (I edited the ticket).

@gabrielgortabns gabrielgortabns changed the title Extension v1.5.2 corrupts credential file Extension v1.5.1 corrupts credential file Nov 6, 2023
@antoniofruci
Copy link
Member

Starting with version 1.5.0 we have improved the credentials security mechanism. This means that if you use your credentials with any version >1.5.x you won't be able to use them again with any older version. Could this be the case?

@gabrielgortabns
Copy link
Author

gabrielgortabns commented Nov 6, 2023

Maybe, will test it. Due to other issues our team switch often between newest version and version 1.4.2, that is last that works with ESM + TS template (issue: #765), so it may be the issue. Will try to test it more, what exactly are conditions when credentials file get corrupted.

E: by testing it seems to corrupt file both when you update or downgrade.

@alisyed-19
Copy link
Member

@gabrielgortabns
The newer version is chnaging how the credentials file is accessed! so first time you upgrade, the tools try to update the saving mechanism of credentials -> This should be a transparent change if everything goes well.
If you downgrade the tools, the credentials gets corrupted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants