HTTP method is empty and URI shows the method

[sullerandras]

I have an existing Ruby on Rails application which is using the Zipkin for tracing. I used the docker image to start the proxy application locally to send the tracing data to Stackdriver Trace.
It does work, but for some reason the "HTTP method" column remains empty on the UI and the URI shows "get" or "post" instead of the actual URI. When i click on a trace, it shows the URI as zipkin.io/http.path property.

How can configure to see the correct URI and HTTP method?

Ruby 2.3.3, zipkin-tracer gem 0.21.0, gcr.io/stackdriver-trace-docker/zipkin-collector docker image "latest" (2 months old).

Here's a screenshot of what i see on the UI:

[denyska]

Hi Andras, Do you mind to capture actual Zipkin span that being sent to the adapter?

On Mon, Mar 27, 2017, 1:03 AM Andras Suller ***@***.***> wrote: I have an existing Ruby on Rails application which is using the Zipkin for tracing. I used the docker image to start the proxy application locally to send the tracing data to Stackdriver Trace. It does work, but for some reason the "HTTP method" column remains empty on the UI and the URI shows "get" or "post" instead of the actual URI. When i click on a trace, it shows the URI as zipkin.io/http.path property. How can configure to see the correct URI and HTTP method? Ruby 2.3.3, zipkin-tracer gem 0.21.0, gcr.io/stackdriver-trace-docker/zipkin-collector docker image "latest" (2 months old). Here's a screenshot of what i see on the UI: [image: stackdriver_trace] <https://cloud.githubusercontent.com/assets/394358/24346096/8bd3abee-1305-11e7-8938-1e730f23802d.png> — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#34>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABL2ZiurWLhE_GZ25bWhIdv5yYy3jphsks5rp21egaJpZM4Mp6nK> .

-- regards, denys

[kevinmdavis]

The "URI" field in the UI is actually showing the span name, which is mapped directly from the Zipkin span name. Looking at the code for the Ruby tracer, it looks like it sets the span name to be the HTTP method which is why you're seeing "post". We also populate the "HTTP Method" column based on the value of the "http.method" annotation, however it looks like that isn't set.

@adriancole In our data model, we typically use the URL or operation name as the span name. Is there any documentation about what values to typically expect for the Zipkin span names?

[codefromthecrypt]

@adriancole <https://github.com/adriancole> In our data model, we typically use the URL or operation name as the span name. Is there any documentation about what values to typically expect for the Zipkin span names?

The span name is usually the method name (even in http). The key part is that it is bounded cardinality as it ends up in a drop-down. URLs typically are not bounded, so make poor zipkin span names. Some do some fancy things like templatize the url such that it is low cardinality. Most libraries default http to method name as that's less likely to result in unbounded cardinality. Most libraries also allow users to override that convention.. https://github.com/openzipkin/zipkin-api/blob/master/thrift/zipkinCore.thrift#L390

[sullerandras]

@denyska Here is an actual span sent to the adapter:

[
    {
        "name": "post",
        "traceId": "daa4dacc668ea2a1",
        "id": "daa4dacc668ea2a1",
        "annotations": [
            {
                "value": "sr",
                "timestamp": 1490665705030831,
                "endpoint": {
                    "ipv4": "192.168.1.2",
                    "port": 443,
                    "serviceName": "[redacted]"
                }
            },
            {
                "value": "ss",
                "timestamp": 1490665705078433,
                "endpoint": {
                    "ipv4": "192.168.1.2",
                    "port": 443,
                    "serviceName": "[redacted]"
                }
            }
        ],
        "binaryAnnotations": [
            {
                "key": "http.path",
                "value": "/[redacted]",
                "endpoint": {
                    "ipv4": "192.168.1.2",
                    "port": 443,
                    "serviceName": "[redacted]"
                }
            }
        ],
        "timestamp": 1490665705030789,
        "duration": 47650,
        "debug": false
    }
]