Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing GRPC #3

Merged
merged 1 commit into from
Jun 27, 2024
Merged

Removing GRPC #3

merged 1 commit into from
Jun 27, 2024

Conversation

marcingrzejszczak
Copy link
Collaborator

Since only HTTP is required to have OTLP support we're going with the minimal version

@marcingrzejszczak marcingrzejszczak added this to the 0.0.1 milestone Jun 26, 2024
@marcingrzejszczak
Copy link
Collaborator Author

In case we ever want to come back to this one. I have a branch with some initial GRPC version working.

@marcingrzejszczak marcingrzejszczak mentioned this pull request Jun 26, 2024
Closed
5 tasks
codefromthecrypt
codefromthecrypt approved these changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@codefromthecrypt codefromthecrypt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, and the rationale was it is both a good start and also the more used direction of otel

@codefromthecrypt codefromthecrypt merged commit 1092c0d into main Jun 27, 2024
3 checks passed
@codefromthecrypt codefromthecrypt deleted the removingGrpc branch June 27, 2024 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codefromthecrypt codefromthecrypt codefromthecrypt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.0.1
Development

Successfully merging this pull request may close these issues.
2 participants
@marcingrzejszczak @codefromthecrypt