Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Spec to point out @id change #29

Open
tschmidtb51 opened this issue Jun 15, 2023 · 1 comment
Open

Update Spec to point out @id change #29

tschmidtb51 opened this issue Jun 15, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@tschmidtb51
Copy link

tschmidtb51 commented Jun 15, 2023

The OpenVEX spec has a section Updating Statements with Inherited Data. This contains two examples and the text in between:

When adding a second statement, the document date needs to be updated, but to preserve the integrity of the original statement we need to keep the original document timestamp. The newly added statement can inherit the document's date to avoid duplication:

This text should also point out that you assigned a new @id ("@id": "https://openvex.dev/docs/example/vex-84822c4e5028c"; basically, you copied the statement one from the document with "@id": "https://openvex.dev/docs/example/vex-9fb3463de1b57" - otherwise you would have to add a last_updated field to the document level).

Nevertheless, I think the current implementation violates the rule from the requirements:

[doc_time_first_isued] MUST equal the oldest [statement_time_first_issued] of all included VEX statements.

@puerco
Copy link
Member

puerco commented Jun 19, 2023

It's a good idea, thanks! I'll add some lines to the spec to reflect that. Perhaps exemplifying both use cases (new document and same document + new version) would be useful too.

@puerco puerco self-assigned this Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants