Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support OpenTelemetry C++ #284

Open
levonet opened this issue Jun 21, 2022 · 3 comments
Open

Support OpenTelemetry C++ #284

levonet opened this issue Jun 21, 2022 · 3 comments
Labels

Comments

@levonet
Copy link

levonet commented Jun 21, 2022

jaeger-client-cpp and opentracing-cpp are DEPRECATED.
An alternative is opentelemetry-cpp. It also supports other exporters.

@miry
Copy link
Collaborator

miry commented Jun 22, 2022

Good catch.

There is an example how opentelemetry-cpp could be built with nginx: https://github.com/kubernetes/ingress-nginx/pull/8585/files or https://github.com/iquirino/nginx-opentelemetry

Here new question should it be in this repo?
If not where the nginx-opentelemetry repo should live?

As I understand it should be under https://github.com/open-telemetry or https://github.com/open-telemetry-contrib

@lucacome What do you think about it?

@miry miry added the question label Jun 22, 2022
@lucacome
Copy link
Collaborator

I know there's some work being done here https://github.com/open-telemetry/opentelemetry-cpp-contrib/tree/main/instrumentation/nginx

I think nginx-opentelemetry under @open-telemetry-contrib makes sense, but not sure what the plans are

@sriemer
Copy link
Contributor

sriemer commented Jul 8, 2022

Speaking for Instana/IBM Observability by Instana APM:

For now, the NGINX OpenTelemetry example is much harder to configure and does not provide huge advantages over the OpenTracing variant. It shares a lot of the same issues like e.g. that subrequests coming from background caching cannot be traced or that the trace continuity requires setting some *propagate* setting. Also response headers aren't supported. We need them for end-user monitoring. We have more custom patches required specific to what we do.

For NGINX OpenTracing we already have to do auto-tracing via a K8s auto-trace mutating webhook controller as our customers aren't able or willing to set up NGINX tracing manually.

IMHO OpenTelemetry needs better integration into NGINX but collaboration with F5 engineering management hasn't been very productive so far for us.
Sure, OpenTelemetry lobby work is on our radar but not with very high priority for now.

How do others see that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants