Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request: Upgade spring-cloud-starter version #123

Open
magnuskvalheim opened this issue Mar 25, 2021 · 2 comments
Open

Request: Upgade spring-cloud-starter version #123

magnuskvalheim opened this issue Mar 25, 2021 · 2 comments

Comments

@magnuskvalheim
Copy link
Contributor

Hi.
There is a fix in recent spring-cloud-starter version for instrumenting kafka and @KafkaListeners.
Would you consider upgrade 0.5.3 -> 0.5.9 (or greater) for next release?

For reference: https://github.com/opentracing-contrib/java-spring-cloud/pull/306/commits
@geoand
Copy link
Collaborator

geoand commented Mar 26, 2021

Definitely!

Would you like to submit a Pull Request updating the version?

magnuskvalheim pushed a commit to magnuskvalheim/java-spring-jaeger that referenced this issue Mar 31, 2021
opentracing-contrib#123 - update opentracing-spring-cloud-starter.ver…
d49516f 
…sion
@magnuskvalheim
Copy link
Contributor Author

Hi @geoand .
Sure - I created a PR: #124

Locally, I couldnt get io.opentracing.contrib.java.spring.web.jaeger.starter.it.JaegerIntegrationTest to run.
I have a docker on my dev machine though.

"Could not find a valid Docker environment. Please see logs and check configuration"

geoand pushed a commit that referenced this issue Mar 31, 2021
@magnuskvalheim
#123 - update opentracing-spring-cloud-starter.version (#124)
7fc816e 
Co-authored-by: bmkva <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@magnuskvalheim @geoand