Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opentracing-spring-cloud-redis-starter RedisClusterConnection wrapped in TracingRedisConnection #336

Open
bivab opened this issue Feb 4, 2022 · 0 comments

Comments

@bivab
Copy link

bivab commented Feb 4, 2022

The Redis aspect will wrap all RedisConnection objects returned by the intercepted call in TracingRedisConnection, although Jedis (not sure if Lettuce too) can return RedisClusterConnection from the getConnection call which should be wrapped as TracingRedisClusterConnection.

In spring, using the actuator, this leads to issues with for instance the Redis health indicator that behaves differently for clustered and non-clustered modes.

See this repository for an example: https://github.com/bivab/opentracing-spring-cloud-redis-starter-demo

Including or excluding opentracing-spring-cloud-redis-starter in pom.xml will lead to different results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant