Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an option to force sampling before tags are set #51

Open
bboreham opened this issue Jan 24, 2020 · 0 comments
Open

Add an option to force sampling before tags are set #51

bboreham opened this issue Jan 24, 2020 · 0 comments

Comments

@bboreham
Copy link

OpenTracing conventions say that sampling.priority >0 should capture the trace. However, when using Jaeger, any tags set before this are ignored jaegertracing/jaeger-client-go#391.

I think this could be done via spanObserver in nethttp.Middleware, if that were called before the method, url, etc., are set.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bboreham