Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request for build support of dashboards-notifications #3056

Closed
praveensameneni opened this issue Jan 7, 2023 · 3 comments
Closed

Request for build support of dashboards-notifications #3056

praveensameneni opened this issue Jan 7, 2023 · 3 comments
Labels
enhancement New Enhancement

Comments

@praveensameneni
Copy link
Member

praveensameneni commented Jan 7, 2023

Is your feature request related to a problem? Please describe

opensearch-project/notifications plugin has both back end and dashboards in a single repo . We are splitting the dashboards part into its own repo - dashboards-notifications repo as requested here..

Describe the solution you'd like

We have created a new repo - dashboards-notifications to support the front end in its own repo and we would like to have build scripts (of dashboards component) pick up the code from dashboards-notifications repo.

Back end plugin repo
Dashboards repo

Describe alternatives you've considered

N/A

Additional context

We will provide the links to PR after the codebase has been migrated to the new repo.

@praveensameneni praveensameneni added enhancement New Enhancement untriaged Issues that have not yet been triaged labels Jan 7, 2023
@gaiksaya
Copy link
Member

gaiksaya commented Jan 10, 2023

Hi @praveensameneni ,

Making sure I understand it right, the dashboard-notification needs build scripts so that it can be built during distribution creation?
If that's the case, adding the scripts/build.sh in the root will do the trick. This is only required if your build script is customized in someway.
Else if nothing is specified, default will be picked up from here

However, I see a script for notificationsDashboards already exists in build repo. Would recommend to move it under new repo so that its easier to maintain on your end.

Thanks!

cc: @peterzhuamazon @prudhvigodithi Please correct if I am wrong.

@ansjcy
Copy link
Member

ansjcy commented Jan 10, 2023

FYI: After moving dashboards-notifications to its own repo, we saw some build and test failures. Here's a related PR to fix the github workflow.

@bbarani
Copy link
Member

bbarani commented Jan 17, 2023

Changes have been completed and we will close this issue after 2.5.0 is released

@bbarani bbarani removed the untriaged Issues that have not yet been triaged label Jan 17, 2023
@bbarani bbarani closed this as completed Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New Enhancement
Projects
None yet
Development

No branches or pull requests

4 participants