Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE/DOCS] Properly handle model group deletion #365

Closed
dbwiddis opened this issue Jan 5, 2024 · 0 comments · Fixed by #376
Closed

[FEATURE/DOCS] Properly handle model group deletion #365

dbwiddis opened this issue Jan 5, 2024 · 0 comments · Fixed by #376
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request v2.12.0

Comments

@dbwiddis
Copy link
Member

dbwiddis commented Jan 5, 2024

Is your feature request related to a problem?

Users can use the ModelGroup step to create a model group, but there's no corresponding deletion. However, the documentation indicates that a model group is automatically deleted when the last model in it is deleted (and you can't delete it until then).

There appears to be an edge case of creating a model group (empty) and then wanting to delete it, but this seems an extremely unlikely scenario to encounter in a workflow environment.

What solution would you like?

Pick one:

  1. add a workflow step to delete a model group, recognizing it will often return a deletion status of "not found". (May be preferable for easier tracking of removing the resource id)
  2. update the deprovision workflow to use the "noop" step to "deprovision" a model group (probably just a quick change in the WorkflowResources enum). (May be preferable if we just want to remove the resource id anyway.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request v2.12.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants