Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Sort Index Dropdown #293

Open
sejli opened this issue Sep 20, 2023 · 7 comments
Open

[FEATURE] Sort Index Dropdown #293

sejli opened this issue Sep 20, 2023 · 7 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@sejli
Copy link
Member

sejli commented Sep 20, 2023

Is your feature request related to a problem?

On domains with a large number of indexes, it may be difficult to find a specific index since the indices list is not sorted, simply displayed what is returned from the backend.
image

What solution would you like?

Sort the index array before displaying them. This should be a simple change here.

What alternatives have you considered?

Combing through large dropdown menus is the only other option, but is inconvenient for users.

Do you have any additional context?

The ML Playground has a similar fix implemented.

@sejli sejli added enhancement New feature or request good first issue Good for newcomers untriaged and removed untriaged labels Sep 20, 2023
@frankschlehofer
Copy link

I can pick up this issue.

@kgcreative
Copy link
Member

For this, please use ComboBox with singleSelection={{ asPlainText: true }} instead of Select. This will also make the index list searchable.

@kgcreative
Copy link
Member

@ashwin-pc -> would this be a good candidate to utilize the new data source component?

@ashwin-pc
Copy link
Member

ashwin-pc commented Oct 12, 2023

@kgcreative yes, the new component should solve this issue. @frankschlehofer there is a new DataSources component thats exposed by the data plugin that should allow the user to use filter the datasource that they need from a long list. https://github.com/opensearch-project/OpenSearch-Dashboards/blob/main/src/plugins/data/public/data_sources/datasource_selector/datasource_selectable.tsx

@frankschlehofer
Copy link

Hi @ashwin-pc, would the DataSources component replace the ComboBox entirely, or would it be used in addition to the ComboBox. I got the ComboBox without the DataSources working now, so I'm just a little unsure what the DataSources component would be doing exactly. Thanks!

@ashwin-pc
Copy link
Member

The current implementation is a combo box. @shanilpa is working on the future iteration of the datasource selector. He is the best person to ask this question to :)

@kgcreative
Copy link
Member

For now let's align on combo box as an incremental improvement. We can consider the data source component once the future iteration is a bit more defined

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants