Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Incontext Insights] follow up issues from #53 #143

Open
5 of 17 tasks
kavilla opened this issue Feb 9, 2024 · 0 comments
Open
5 of 17 tasks

[Incontext Insights] follow up issues from #53 #143

kavilla opened this issue Feb 9, 2024 · 0 comments
Assignees
@kavilla
Labels
enhancement New feature or request

Comments

@kavilla
Copy link
Member

kavilla commented Feb 9, 2024 •
edited
Loading

Address comments
#53

Fast follows:

  • Change setSuggestionId to setSuggestion within the registry code
  • Clean up tsconfig adding root level config.ts code PR
  • Ref to icon instead of querying the ref of the anchor for it comment
  • Cypress tests
  • Break popover body down into different functional components. PR
  • Consume in alerting dashboards plugin
  • UI Setting? PR
  • Increase delay PR
  • Onclick to document forces fade out behavior PR

Next steps (but not fast follows)

  • Research and potentially refactor to consider animation in code display: none issue prevents animation code
  • Add enabled config to repo and add to build repo env variable code
  • Convert to generic component into OSD and extend in Dashboards Assistant comment
  • Convert wrapper component to query DOM by custom attribute and mutate elements
    • Previous step will make this easier
  • Add chat icon to OpenSearch Dashboards logos so that this plugin and other plugins can reference the icon with getChrome().logos
  • Consider making key suggestions retrieve from saved objects or at least make it configurable.
  • Convert popover to a modified OUI styled component
@kavilla kavilla added enhancement New feature or request untriaged Issues that have not yet been triaged labels Feb 9, 2024
@kavilla kavilla mentioned this issue Feb 9, 2024
Merged
@kavilla kavilla removed the untriaged Issues that have not yet been triaged label Feb 9, 2024
@kavilla kavilla self-assigned this Feb 9, 2024
@kavilla kavilla changed the title [Incontext Insights] address issues from #53 [Incontext Insights] follow up issues from #53 Feb 9, 2024
@kavilla kavilla mentioned this issue Apr 2, 2024
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kavilla kavilla

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kavilla