Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Decouple Alerting and Anomaly Detection #988

Open
amitgalitz opened this issue Jul 10, 2023 · 1 comment
Open

[FEATURE] Decouple Alerting and Anomaly Detection #988

amitgalitz opened this issue Jul 10, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@amitgalitz
Copy link
Member

Is your feature request related to a problem?

Currently Anomaly Detection and Alerting code is coupled throughout the backend in order to create an alerting monitor on top of an existing anomaly detector. The Alerting plugin currently queries the anomaly detection system indices directly, and also has specific code that checks if Anomaly Detection has their filter by backend role setting enabled. We would like to change this so we have a solution that decouples Alerting and Anomaly Detection code as well as creates supports for further enhancements.

What solution would you like?

The first step of change we would like to make is to utilize Common Utils (Alerting already has an interface there https://github.com/sbcd90/common-utils/blob/514fa7acca686c6142ea847cfc1906398886fe41/src/main/kotlin/org/opensearch/commons/alerting/AlertingPluginInterface.kt) in order for Alerting to interact with the transport layer of Anomaly Detection. This has already been done in between alerting and security analytics and will require similar changes. On the alerting side we will add calls to a callback function that Anomaly Detection will register whenever a CRUD operations needs to be done on an detector. The changes will be similar to the ones done here 37b81fa#diff-68866b22ed9703814b4d5db8d3488872bcb972086ecaca10c9b8bfd54db981bc.

@amitgalitz amitgalitz added enhancement New feature or request untriaged labels Jul 10, 2023
@lezzago
Copy link
Member

lezzago commented Jul 10, 2023

related to opensearch-project/anomaly-detection#947

@lezzago lezzago removed the untriaged label Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants