Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Breaking changes workflow should not run on main #13029

Closed
dblock opened this issue Apr 2, 2024 · 2 comments · Fixed by #13030
Closed

[BUG] Breaking changes workflow should not run on main #13029

dblock opened this issue Apr 2, 2024 · 2 comments · Fixed by #13030
Assignees
Labels
bug Something isn't working Build Build Tasks/Gradle Plugin, groovy scripts, build tools, Javadoc enforcement. untriaged

Comments

@dblock
Copy link
Member

dblock commented Apr 2, 2024

Describe the bug

Breaking changes are expected on main. Currently the job introduced in #12974 is failing on push.

Related component

Build

To Reproduce

https://github.com/opensearch-project/OpenSearch/actions/runs/8525228788/job/23351663380

Expected behavior

Main build to be green.

Additional Details

No response

@dblock dblock added bug Something isn't working untriaged labels Apr 2, 2024
@github-actions github-actions bot added the Build Build Tasks/Gradle Plugin, groovy scripts, build tools, Javadoc enforcement. label Apr 2, 2024
@peternied
Copy link
Member

peternied commented Apr 2, 2024

@dblock Thanks for creating this issue, rather than have this test fail on build should it do some other action for just pull request vs push? Even if intentional, change that break the public API will break the builds of downstream plugins.

While in main we certainly make breaking changes, often changes are make specifically to go into the next release in the downstream 2.x branches.

@dblock
Copy link
Member Author

dblock commented Apr 2, 2024

What's the baseline for the failure, meaning will it ever be green for PRs on main?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Build Build Tasks/Gradle Plugin, groovy scripts, build tools, Javadoc enforcement. untriaged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants