Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use spdx/tools-golang rather than internal spdx.go file #276

Open
nishakm opened this issue Sep 28, 2022 · 2 comments
Open

Use spdx/tools-golang rather than internal spdx.go file #276

nishakm opened this issue Sep 28, 2022 · 2 comments
Labels
tech debt Technical Debt

Comments

@nishakm
Copy link
Collaborator

nishakm commented Sep 28, 2022

Upstream spdx tools already define structs which reflect the data model for each version of the specification. Rather than duplicate work, use the upstream models.

@nishakm nishakm added the tech debt Technical Debt label Sep 28, 2022
@ba11b0y
Copy link
Contributor

ba11b0y commented Feb 9, 2023

Is this up for grabs? If yes, I'd like to work on this as my first contribution here!

@ba11b0y
Copy link
Contributor

ba11b0y commented Feb 21, 2023

From what I could understand was, instead of defining Relationship here

type Relationship struct {

A better idea is to import tools-golang and directly refer to https://github.com/spdx/tools-golang/blob/main/spdx/v2/v2_3/relationship.go#L10

Is this the right approach to follow for all others?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech debt Technical Debt
Projects
None yet
Development

No branches or pull requests

2 participants